Changeset View
Changeset View
Standalone View
Standalone View
sys/geom/geom_io.c
Show First 20 Lines • Show All 203 Lines • ▼ Show 20 Lines | if (bp2 != NULL) { | ||||
/* | /* | ||||
* BIO_ORDERED flag may be used by disk drivers to enforce | * BIO_ORDERED flag may be used by disk drivers to enforce | ||||
* ordering restrictions, so this flag needs to be cloned. | * ordering restrictions, so this flag needs to be cloned. | ||||
* BIO_UNMAPPED and BIO_VLIST should be inherited, to properly | * BIO_UNMAPPED and BIO_VLIST should be inherited, to properly | ||||
* indicate which way the buffer is passed. | * indicate which way the buffer is passed. | ||||
* Other bio flags are not suitable for cloning. | * Other bio flags are not suitable for cloning. | ||||
*/ | */ | ||||
bp2->bio_flags = bp->bio_flags & | bp2->bio_flags = bp->bio_flags & | ||||
(BIO_ORDERED | BIO_UNMAPPED | BIO_VLIST); | (BIO_ORDERED | BIO_UNMAPPED | BIO_VLIST | BIO_NORETRY); | ||||
imp: Why not both clone and duplicate? That's incredibly short sighted. No comment was updated here. | |||||
Not Done Inline ActionsI was going to wait until clone and duplicate get converged, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223838 avg: I was going to wait until clone and duplicate get converged, https://bugs.freebsd. | |||||
bp2->bio_length = bp->bio_length; | bp2->bio_length = bp->bio_length; | ||||
bp2->bio_offset = bp->bio_offset; | bp2->bio_offset = bp->bio_offset; | ||||
bp2->bio_data = bp->bio_data; | bp2->bio_data = bp->bio_data; | ||||
bp2->bio_ma = bp->bio_ma; | bp2->bio_ma = bp->bio_ma; | ||||
bp2->bio_ma_n = bp->bio_ma_n; | bp2->bio_ma_n = bp->bio_ma_n; | ||||
bp2->bio_ma_offset = bp->bio_ma_offset; | bp2->bio_ma_offset = bp->bio_ma_offset; | ||||
bp2->bio_attribute = bp->bio_attribute; | bp2->bio_attribute = bp->bio_attribute; | ||||
if (bp->bio_cmd == BIO_ZONE) | if (bp->bio_cmd == BIO_ZONE) | ||||
▲ Show 20 Lines • Show All 837 Lines • Show Last 20 Lines |
Why not both clone and duplicate? That's incredibly short sighted. No comment was updated here.