Changeset View
Changeset View
Standalone View
Standalone View
sys/cam/ata/ata_da.c
Show First 20 Lines • Show All 2,340 Lines • ▼ Show 20 Lines | #ifdef ADA_TEST_FAILURE | ||||
return; | return; | ||||
} | } | ||||
#endif | #endif | ||||
KASSERT((bp->bio_flags & BIO_UNMAPPED) == 0 || | KASSERT((bp->bio_flags & BIO_UNMAPPED) == 0 || | ||||
round_page(bp->bio_bcount + bp->bio_ma_offset) / | round_page(bp->bio_bcount + bp->bio_ma_offset) / | ||||
PAGE_SIZE == bp->bio_ma_n, | PAGE_SIZE == bp->bio_ma_n, | ||||
("Short bio %p", bp)); | ("Short bio %p", bp)); | ||||
cam_fill_ataio(ataio, | cam_fill_ataio(ataio, | ||||
ada_retry_count, | (bp->bio_flags & BIO_NORETRY) != 0 ? 0 : ada_retry_count, | ||||
adadone, | adadone, | ||||
imp: I think this is a really bad idea. You're putting policy here that doesn't belong. How do we… | |||||
Not Done Inline ActionsAs already discussed with mav I will remove the timeout change. avg: As already discussed with mav I will remove the timeout change. | |||||
rw_op, | rw_op, | ||||
0, | 0, | ||||
data_ptr, | data_ptr, | ||||
bp->bio_bcount, | bp->bio_bcount, | ||||
ada_default_timeout*1000); | ada_default_timeout*1000); | ||||
if ((softc->flags & ADA_FLAG_CAN_NCQ) && tag_code) { | if ((softc->flags & ADA_FLAG_CAN_NCQ) && tag_code) { | ||||
if (bp->bio_cmd == BIO_READ) { | if (bp->bio_cmd == BIO_READ) { | ||||
▲ Show 20 Lines • Show All 1,262 Lines • Show Last 20 Lines |
I think this is a really bad idea. You're putting policy here that doesn't belong. How do we know this is the right thing to do? I don't like it at all.