Changeset View
Changeset View
Standalone View
Standalone View
math/ambit/Makefile
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
# $FreeBSD$ | |||||
PORTNAME= ambit | |||||
DISTVERSIONPREFIX= v | |||||
DISTVERSION= 0.2-37 | |||||
DISTVERSIONSUFFIX= -g9c7049a | |||||
CATEGORIES= math | |||||
MAINTAINER= yuri@FreeBSD.org | |||||
COMMENT= C++ library for tensor product calculations | |||||
LICENSE= GPLv3 | |||||
LICENSE_FILE= ${WRKSRC}/COPYING | |||||
LIB_DEPENDS= libhdf5.so:science/hdf5 \ | |||||
libsz.so:science/szip | |||||
USES= cmake:outsource | |||||
USE_GITHUB= yes | |||||
GH_ACCOUNT= jturney | |||||
# some declared cmake options do nothing: see https://github.com/jturney/ambit/issues/25 and the patch | |||||
CMAKE_ARGS+= -DSHARED_ONLY:BOOL=ON | |||||
CMAKE_ARGS+= -DENABLE_TESTS:BOOL=OFF # https://github.com/jturney/ambit/issues/24 | |||||
.include <bsd.port.options.mk> | |||||
tcberner: ^ I think using `<bsd.port.pre.mk>` (and `<bsd.port.post.mk>` at the bottom) would be more… | |||||
.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1100000 | |||||
# It requires clang version >3.6 | |||||
BUILD_DEPENDS= clang38:lang/clang38 | |||||
tcbernerUnsubmitted Done Inline Actions^ I'm not sure whether hard-depending on one version of clang is a great idea as they get dropped eventually. tcberner: ^ I'm not sure whether hard-depending on one version of clang is a great idea as they get… | |||||
yuriAuthorUnsubmitted Done Inline ActionsI am not sure how this can be solved. Eventually, every specific version will be dropped. The right way would have been having USES=compiler:clang>3.6. This already came up before, without a clear solution. yuri: I am not sure how this can be solved. Eventually, every specific version will be dropped.
The… | |||||
RUN_DEPENDS= clang38:lang/clang38 | |||||
CC= clang38 | |||||
CXX= clang++38 | |||||
Done Inline Actions^ you need += here. After including bsd.pre.mk BUILD_DEPENDS already contains cmake:devel/cmake from the USES=cmake line. Which you override here :) So this port will fail to configure on FreeBSD < 11, as cmake is not installed. root@103amd32-yuri:/usr/ports/math/ambit # make -VBUILD_DEPENDS clang38:lang/clang38 /usr/local/bin/ccache:devel/ccache tcberner: ^ you **need** += here. After including `bsd.pre.mk` `BUILD_DEPENDS` already contains `cmake… | |||||
Not Done Inline ActionsThanks for catching this! yuri: Thanks for catching this! | |||||
.endif | |||||
.include <bsd.port.mk> |
^ I think using <bsd.port.pre.mk> (and <bsd.port.post.mk> at the bottom) would be more proper than using <bsd.options.mk>, as you are really not using any option specific stuff here.
https://www.freebsd.org/doc/en/books/porters-handbook/dads-after-port-mk.html