Page MenuHomeFreeBSD
Differential D2432 Diff 5332 sys/arm/amlogic/aml8726/files.aml8726

Changeset View

Standalone View

View Options

sys/arm/amlogic/aml8726/files.aml8726

Context not available.
arm/amlogic/aml8726/aml8726_identsoc.c standard arm/amlogic/aml8726/aml8726_identsoc.c standard
andrewUnsubmitted
Not Done
Inline Actions

This was correct, it should only be selected by smp as this file should only contain smp related code.

andrew: This was correct, it should only be selected by smp as this file should only contain smp…
john-feith.comAuthorUnsubmitted
Not Done
Inline Actions

My change made the file dependent on both SMP and GIC since SMP is not possible on Amlogic without
GIC.

The change causes a kernel configured for SMP without GIC to fail at build time which seems desirable.

Without the change a kernel build may succeed for a impossible configuration.

What's the downside of making aml8726_mp.c dependent on GIC?

john-feith.com: My change made the file dependent on both SMP and GIC since SMP is not possible on Amlogic…
arm/amlogic/aml8726/aml8726_ccm.c standard arm/amlogic/aml8726/aml8726_ccm.c standard
arm/amlogic/aml8726/aml8726_clkmsr.c standard arm/amlogic/aml8726/aml8726_clkmsr.c standard
arm/amlogic/aml8726/aml8726_pic.c standard arm/amlogic/aml8726/aml8726_pic.c optional aml_pic
arm/amlogic/aml8726/aml8726_rtc.c standard arm/amlogic/aml8726/aml8726_rtc.c standard
arm/amlogic/aml8726/aml8726_timer.c standard arm/amlogic/aml8726/aml8726_timer.c standard
arm/amlogic/aml8726/aml8726_wdt.c standard arm/amlogic/aml8726/aml8726_wdt.c standard
Context not available.