Changeset View
Standalone View
distinfo
- This file was added.
TIMESTAMP = 1498559433 | |||||
SHA256 (tensorflow-tensorflow-v1.2.0_GH0.tar.gz) = 03dbf7548d1fc1c11ed58da5fa68616f795c819f868f43478cbcaa26abed374f | |||||
SIZE (tensorflow-tensorflow-v1.2.0_GH0.tar.gz) = 14489600 | |||||
SHA256 (amutu-tensorflow_third_party-c528072_GH0.tar.gz) = 60ef19bdf5e7d0af05275a0ba29bc80c35368c83a2bfc10f61f7c60301ee236b | |||||
SIZE (amutu-tensorflow_third_party-c528072_GH0.tar.gz) = 170855167 | |||||
SHA256 (patch-WORKSPACE) = 6b4da741f6f3c28cb06214f62db29c852f7142863ed75277110ef043fe70f230 | |||||
SIZE (patch-WORKSPACE) = 21385 | |||||
SHA256 (patch-tensorflow_workspace.bzl) = 4a4fdd5d352debef469cdcf822cd24a99d94d1c6091e3d777b61bb8bc80c01db | |||||
SIZE (patch-tensorflow_workspace.bzl) = 121036 | |||||
lwhsu: let's make these external patches versioned and be placed under `tensorflow` in distfiles… | |||||
amutu_amutu.comAuthorUnsubmitted Not Done Inline Actionsin fact, the hash value in the PATCH_SITES is a git commit, so it is some meaning of version. but I am willing to change because version number is more readable.
amutu_amutu.com: in fact, the hash value in the PATCH_SITES is a git commit, so it is some meaning of version. | |||||
lwhsuUnsubmitted Not Done Inline ActionsThe main point is trying to prevent file name collision in user's /usr/ports/distfiles directory in the future updates. What I suggest here is, putting them to a specified directory, such as /usr/ports/distfiles/tensorflow , and naming patch files like patch-WORKSPACE-some_hashcode or patch-WORKSPACE-v1.2.3. Using a subdirectory such as /usr/ports/distfiles/tensorflow/some_hashcode or /usr/ports/distfiles/tensorflow/v1.2.3 is also a possible way if renaming patch files is unpractical. lwhsu: The main point is trying to prevent file name collision in user's `/usr/ports/distfiles`… | |||||
amutu_amutu.comAuthorUnsubmitted Not Done Inline ActionsGot it,thank you for your explanation!I have changed the external patch like this: PATCH_SITES= https://raw.githubusercontent.com/amutu/tensorflow-port/v${PORTVERSION}/files/ Will update the review patch later. amutu_amutu.com: Got it,thank you for your explanation!I have changed the external patch like this:… |
let's make these external patches versioned and be placed under tensorflow in distfiles directory, to prevent name collisions in the future.