Differential D11290 Diff 30026 archivers/brotli/Makefile

Changeset View

Standalone View

archivers/brotli/Makefile

	# Created by: Sergey A. Osokin <osa@FreeBSD.org>			# Created by: Sergey A. Osokin <osa@FreeBSD.org>
	# $FreeBSD$			# $FreeBSD$

	PORTNAME= libbrotli			PORTNAME= brotli
	PORTVERSION= 1.0			PORTVERSION= 0.6.0
	DISTVERSIONPREFIX= ${PORTNAME}-			DISTVERSIONPREFIX= v
				matUnsubmitted Done Inline Actions PORTEPOCH. mat: PORTEPOCH.
	PORTREVISION= 6			PORTEPOCH= 1
	CATEGORIES= devel archivers			CATEGORIES= archivers devel

	MAINTAINER= osa@FreeBSD.org			MAINTAINER= osa@FreeBSD.org
	COMMENT= Library for generic-purpose lossless compression algorithm			COMMENT= Generic-purpose lossless compression algorithm

	LICENSE= MIT			LICENSE= MIT

	BROTLI_VERSION= v0.4.0

	USE_GITHUB= yes			USE_GITHUB= yes
				matUnsubmitted Not Done Inline Actions This should be ?=, and also only `brotli-static`. mat: This should be ?=, and also only `brotli-static`.
	GH_ACCOUNT= bagder google:brotli			GH_ACCOUNT= google
	GH_PROJECT= brotli:brotli
	GH_TAGNAME= ${BROTLI_VERSION}:brotli
	GH_SUBDIR= brotli:brotli

				matUnsubmitted Done Inline Actions DISTVERSIONPREFIX. mat: DISTVERSIONPREFIX.
	USES= pkgconfig autoreconf libtool compiler:c++0x pathfix			OPTIONS_DEFINE= STATIC
	GNU_CONFIGURE= yes			OPTIONS_EXCLUDE= STATIC
				matUnsubmitted Done Inline Actions So, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined behavior. mat: So, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined…
				brnrdAuthorUnsubmitted Not Done Inline Actions It was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port. Noticed there's no documentation in porter's handbook. brnrd: It was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port.
				OPTIONS_SUB= yes

				USES= cmake:outsource compiler:c++0x pkgconfig
				matUnsubmitted Not Done Inline Actions So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop options and use a `.if defined(STATIC_ONLY)` / `.else` mat: So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop…
	USE_LDCONFIG= yes			USE_LDCONFIG= yes

	pre-configure:			CMAKE_ARGS= -DBUILD_TEST=OFF
	cd ${WRKSRC} && ./autogen.sh			STATIC_CMAKE_ON= -DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON

				post-install:
				@${LN} -s libbrotlicommon.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlicommon.so.0
				matUnsubmitted Not Done Inline Actions Having a static option enabling static libs, ok, why not, but disabling the shared libs, no. Unless you provide a slave port that installs the static libs. mat: Having a static option enabling static libs, ok, why not, but disabling the shared libs, no.
				i.dani_outlook.comUnsubmitted Not Done Inline Actions I think this is a problem of brotli itself - it's not possible to have both types of libraries. See: https://github.com/google/brotli/issues/542 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218851#c9 i.dani_outlook.com: I think this is a problem of brotli itself - it's not possible to have both types of libraries.
				matUnsubmitted Not Done Inline Actions Then create a archivers/brotli-static with and use `OPTIONS_EXCLUDE=STATIC`/`OPTIONS_SLAVE=STATIC` mat: Then create a archivers/brotli-static with and use…
				matUnsubmitted Done Inline Actions Or just do not provide an option to get static libs, nobody should ever be using them. mat: Or just do not provide an option to get static libs, nobody should ever be using them.
				brnrdAuthorUnsubmitted Not Done Inline Actions Agree. This was on request of osa@ (see PR). Gone now. Behavior of brotli cmake is also questionable, it is either or, not both. (if you only disable DYNAMIC, you don't get static either but still dynamic) brnrd: Agree. This was on request of osa@ (see PR). Gone now. Behavior of brotli cmake is also…
				@${LN} -s libbrotlidec.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlidec.so.0
				@${LN} -s libbrotlienc.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlienc.so.0

	.include <bsd.port.mk>			.include <bsd.port.mk>