Changeset View
Standalone View
archivers/brotli/Makefile
# Created by: Sergey A. Osokin <osa@FreeBSD.org> | # Created by: Sergey A. Osokin <osa@FreeBSD.org> | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= libbrotli | PORTNAME= brotli | ||||
PORTVERSION= 1.0 | PORTVERSION= 0.6.0 | ||||
DISTVERSIONPREFIX= ${PORTNAME}- | DISTVERSIONPREFIX= v | ||||
mat: PORTEPOCH. | |||||
PORTREVISION= 6 | PORTEPOCH= 1 | ||||
CATEGORIES= devel archivers | CATEGORIES= archivers devel | ||||
MAINTAINER= osa@FreeBSD.org | MAINTAINER= osa@FreeBSD.org | ||||
COMMENT= Library for generic-purpose lossless compression algorithm | COMMENT= Generic-purpose lossless compression algorithm | ||||
LICENSE= MIT | LICENSE= MIT | ||||
BROTLI_VERSION= v0.4.0 | |||||
USE_GITHUB= yes | USE_GITHUB= yes | ||||
Not Done Inline ActionsThis should be ?=, and also only brotli-static. mat: This should be ?=, and also only `brotli-static`. | |||||
GH_ACCOUNT= bagder google:brotli | GH_ACCOUNT= google | ||||
GH_PROJECT= brotli:brotli | |||||
GH_TAGNAME= ${BROTLI_VERSION}:brotli | |||||
GH_SUBDIR= brotli:brotli | |||||
Done Inline ActionsDISTVERSIONPREFIX. mat: DISTVERSIONPREFIX. | |||||
USES= pkgconfig autoreconf libtool compiler:c++0x pathfix | USES= cmake:outsource compiler:c++0x pkgconfig | ||||
Not Done Inline ActionsSo one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop options and use a .if defined(STATIC_ONLY) / .else mat: So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop… | |||||
GNU_CONFIGURE= yes | |||||
USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
Done Inline ActionsSo, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined behavior. mat: So, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined… | |||||
Not Done Inline ActionsIt was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port. brnrd: It was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port. | |||||
pre-configure: | CMAKE_ARGS= -DBUILD_TEST=OFF | ||||
cd ${WRKSRC} && ./autogen.sh | |||||
post-install: | |||||
@${LN} -s libbrotlicommon.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlicommon.so.0 | |||||
@${LN} -s libbrotlidec.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlidec.so.0 | |||||
Not Done Inline ActionsHaving a static option enabling static libs, ok, why not, but disabling the shared libs, no. Unless you provide a slave port that installs the static libs. mat: Having a static option enabling static libs, ok, why not, but disabling the shared libs, no. | |||||
Not Done Inline ActionsI think this is a problem of brotli itself - it's not possible to have both types of libraries. See: i.dani_outlook.com: I think this is a problem of brotli itself - it's not possible to have both types of libraries. | |||||
Not Done Inline ActionsThen create a archivers/brotli-static with and use OPTIONS_EXCLUDE=STATIC/OPTIONS_SLAVE=STATIC mat: Then create a archivers/brotli-static with and use… | |||||
Done Inline ActionsOr just do not provide an option to get static libs, nobody should ever be using them. mat: Or just do not provide an option to get static libs, nobody should ever be using them. | |||||
Not Done Inline ActionsAgree. This was on request of osa@ (see PR). Gone now. brnrd: Agree. This was on request of osa@ (see PR). Gone now.
Behavior of brotli cmake is also… | |||||
@${LN} -s libbrotlienc.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libbrotlienc.so.0 | |||||
.include <bsd.port.mk> | .include <bsd.port.mk> |
PORTEPOCH.