Page MenuHomeFreeBSD
Differential D11290 Diff 29891 archivers/brotli/Makefile

Changeset View

Standalone View

View Options

archivers/brotli/Makefile

# Created by: Sergey A. Osokin <osa@FreeBSD.org> # Created by: Sergey A. Osokin <osa@FreeBSD.org>
# $FreeBSD$ # $FreeBSD$
PORTNAME= libbrotli PORTNAME= brotli
PORTVERSION= 1.0 PORTVERSION= 0.6.0
DISTVERSIONPREFIX= ${PORTNAME}- CATEGORIES= archivers devel
matUnsubmitted
Done
Inline Actions

PORTEPOCH.

mat: PORTEPOCH.
PORTREVISION= 6
CATEGORIES= devel archivers
MAINTAINER= osa@FreeBSD.org MAINTAINER= osa@FreeBSD.org
COMMENT= Library for generic-purpose lossless compression algorithm COMMENT= Library for generic-purpose lossless compression algorithm
LICENSE= MIT LICENSE= MIT
BROTLI_VERSION= v0.4.0
USE_GITHUB= yes USE_GITHUB= yes
matUnsubmitted
Not Done
Inline Actions

This should be ?=, and also only brotli-static.

mat: This should be ?=, and also only `brotli-static`.
GH_ACCOUNT= bagder google:brotli GH_ACCOUNT= google
GH_PROJECT= brotli:brotli GH_TAGNAME= v${PORTVERSION}
matUnsubmitted
Done
Inline Actions

DISTVERSIONPREFIX.

mat: DISTVERSIONPREFIX.
GH_TAGNAME= ${BROTLI_VERSION}:brotli
GH_SUBDIR= brotli:brotli
USES= pkgconfig autoreconf libtool compiler:c++0x pathfix USES= pkgconfig cmake libtool compiler:c++0x
matUnsubmitted
Done
Inline Actions

So, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined behavior.

mat: So, mmm, this has OPTIONS_EXCLUDE=STATIC and OPTIONS_SLAVE=STATIC, I figure this is undefined…
brnrdAuthorUnsubmitted
Not Done
Inline Actions

It was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port.
Noticed there's no documentation in porter's handbook.

brnrd: It was my impression that this was how it works, _EXCLUDE in master- and _SLAVE in slave-port.
matUnsubmitted
Not Done
Inline Actions

So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop options and use a .if defined(STATIC_ONLY) / .else

mat: So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop…
GNU_CONFIGURE= yes
USE_LDCONFIG= yes USE_LDCONFIG= yes
pre-configure: CMAKE_FLAGS= -DBUILD_TEST=OFF
cd ${WRKSRC} && ./autogen.sh
.include <bsd.port.mk> .include <bsd.port.mk>
matUnsubmitted
Not Done
Inline Actions

Having a static option enabling static libs, ok, why not, but disabling the shared libs, no. Unless you provide a slave port that installs the static libs.

mat: Having a static option enabling static libs, ok, why not, but disabling the shared libs, no.
i.dani_outlook.comUnsubmitted
Not Done
Inline Actions

I think this is a problem of brotli itself - it's not possible to have both types of libraries. See:
https://github.com/google/brotli/issues/542
and
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218851#c9

i.dani_outlook.com: I think this is a problem of brotli itself - it's not possible to have both types of libraries.
matUnsubmitted
Not Done
Inline Actions

Then create a archivers/brotli-static with and use OPTIONS_EXCLUDE=STATIC/OPTIONS_SLAVE=STATIC

mat: Then create a archivers/brotli-static with and use…
matUnsubmitted
Done
Inline Actions

Or just do not provide an option to get static libs, nobody should ever be using them.

mat: Or just do not provide an option to get static libs, nobody should ever be using them.
brnrdAuthorUnsubmitted
Not Done
Inline Actions

Agree. This was on request of osa@ (see PR). Gone now.
Behavior of brotli cmake is also questionable, it is either or, not both. (if you only disable DYNAMIC, you don't get static either but still dynamic)

brnrd: Agree. This was on request of osa@ (see PR). Gone now. Behavior of brotli cmake is also…