Changeset View
Standalone View
distinfo
- This file was added.
TIMESTAMP = 1497272083 | |||||
SHA256 (tensorflow-tensorflow-v1.1.0_GH0.tar.gz) = aad4470f52fa59f54de7b9a2da727429e6755d91d756f245f952698c42a60027 | |||||
SIZE (tensorflow-tensorflow-v1.1.0_GH0.tar.gz) = 11651671 | |||||
SHA256 (amutu-tensorflow_third_party-9c2d26b_GH0.tar.gz) = bc20c07a354c19379ea9fba809e3310ccafa814eba9ae73e22c1afc8f117a930 | |||||
SIZE (amutu-tensorflow_third_party-9c2d26b_GH0.tar.gz) = 170128405 | |||||
lwhsu: let's make these external patches versioned and be placed under `tensorflow` in distfiles… | |||||
Not Done Inline Actionsin fact, the hash value in the PATCH_SITES is a git commit, so it is some meaning of version. but I am willing to change because version number is more readable.
amutu_amutu.com: in fact, the hash value in the PATCH_SITES is a git commit, so it is some meaning of version. | |||||
Not Done Inline ActionsThe main point is trying to prevent file name collision in user's /usr/ports/distfiles directory in the future updates. What I suggest here is, putting them to a specified directory, such as /usr/ports/distfiles/tensorflow , and naming patch files like patch-WORKSPACE-some_hashcode or patch-WORKSPACE-v1.2.3. Using a subdirectory such as /usr/ports/distfiles/tensorflow/some_hashcode or /usr/ports/distfiles/tensorflow/v1.2.3 is also a possible way if renaming patch files is unpractical. lwhsu: The main point is trying to prevent file name collision in user's `/usr/ports/distfiles`… | |||||
Not Done Inline ActionsGot it,thank you for your explanation!I have changed the external patch like this: PATCH_SITES= https://raw.githubusercontent.com/amutu/tensorflow-port/v${PORTVERSION}/files/ Will update the review patch later. amutu_amutu.com: Got it,thank you for your explanation!I have changed the external patch like this:… |
let's make these external patches versioned and be placed under tensorflow in distfiles directory, to prevent name collisions in the future.