Differential D9903 Diff 26715 lib/libc/stdlib/set_constraint_handler_s.c

Changeset View

Standalone View

lib/libc/stdlib/set_constraint_handler_s.c

This file was added.

				/*-
				* Copyright (c) 2017 Juniper Networks. All rights reserved.
				*
				* Redistribution and use in source and binary forms, with or without
				* modification, are permitted provided that the following conditions
				* are met:
				* 1. Redistributions of source code must retain the above copyright
				* notice, this list of conditions and the following disclaimer.
				* 2. Redistributions in binary form must reproduce the above copyright
				* notice, this list of conditions and the following disclaimer in the
				* documentation and/or other materials provided with the distribution.
				*
				* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
				* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
				* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
				* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
				* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
				* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
				* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
				* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
				* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
				* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
				* SUCH DAMAGE.
				*/

				#include <sys/cdefs.h>
				__FBSDID("$FreeBSD$");

				#include <errno.h>
				#include <stddef.h>
				#include <stdlib.h>

				/* rationale recommends allocating new memory each time */
				static constraint_handler_t *_ch = NULL;

				constraint_handler_t
				set_constraint_handler_s(constraint_handler_t handler)
				{
				constraint_handler_t ret;

				kibUnsubmitted Not Done Inline Actions Style prohibits local declarations with initialization. Also, a blank line is needed between decl section and the first statement. kib: Style prohibits local declarations with initialization. Also, a blank line is needed between…
				kibUnsubmitted Not Done Inline Actions Not fixed. kib: Not fixed.
				ret = NULL;
				kibUnsubmitted Not Done Inline Actions Use _ch == NULL comparision for pointers. Note that next if() uses style-compliant check for the same condition. kib: Use _ch == NULL comparision for pointers. Note that next if() uses style-compliant check for…
				if (_ch != NULL)
				ret = *_ch;
				if (_ch == NULL)
				_ch = (constraint_handler_t *)
				kibUnsubmitted Not Done Inline Actions Continuation line should have 4-spaces indent. kib: Continuation line should have 4-spaces indent.
				malloc(sizeof(constraint_handler_t));
				kibUnsubmitted Not Done Inline Actions Same. kib: Same.
				if (_ch != NULL)
				*_ch = handler;
				kibUnsubmitted Not Done Inline Actions return (ret); kib: return (ret);
				kibUnsubmitted Not Done Inline Actions Not fixed. kib: Not fixed.
				return (ret);
				}
				kibUnsubmitted Not Done Inline Actions return (ret); (still) kib: return (ret); (still)

				void
				kibUnsubmitted Not Done Inline Actions If your intent in selecting the function name was to put it into the implementation-private namespace to minimize issues with statically-linked programs, then __throw_contraint_handler_s is a better name for the function. kib: If your intent in selecting the function name was to put it into the implementation-private…
				__throw_constraint_handler_s(const char * restrict msg, errno_t error)
				{
				kibUnsubmitted Not Done Inline Actions There must be an empty line after '{' and the first statement in a function without locals. if (_ch != NULL && _ch != NULL) kib:* There must be an empty line after '{' and the first statement in a function without locals. ```…
				if (_ch != NULL && *_ch != NULL)
				(*_ch)(msg, NULL, error);
				kibUnsubmitted Not Done Inline Actions != NULL still not applied. kib: != NULL still not applied.
				}

				void
				abort_handler_s(const char * restrict msg __unused,
				kibUnsubmitted Not Done Inline Actions Continuation line should have 4-spaces ident. kib: Continuation line should have 4-spaces ident.
				void * restrict ptr __unused, errno_t error __unused)
				{
				kibUnsubmitted Not Done Inline Actions Blank line. kib: Blank line.
				kibUnsubmitted Not Done Inline Actions still. kib: still.

				abort();
				}

				void
				kibUnsubmitted Not Done Inline Actions 4-spaces indent. kib: 4-spaces indent.
				ignore_handler_s(const char * restrict msg __unused,
				void * restrict ptr __unused, errno_t error __unused)
				{
				}