Changeset View
Changeset View
Standalone View
Standalone View
sys/cddl/dev/dtrace/arm/dtrace_subr.c
| Show First 20 Lines • Show All 195 Lines • ▼ Show 20 Lines | dtrace_trap(struct trapframe *frame, u_int type) | ||||
| if ((cpu_core[curcpu].cpuc_dtrace_flags & CPU_DTRACE_NOFAULT) != 0) { | if ((cpu_core[curcpu].cpuc_dtrace_flags & CPU_DTRACE_NOFAULT) != 0) { | ||||
| /* | /* | ||||
| * There are only a couple of trap types that are expected. | * There are only a couple of trap types that are expected. | ||||
| * All the rest will be handled in the usual way. | * All the rest will be handled in the usual way. | ||||
| */ | */ | ||||
| switch (type) { | switch (type) { | ||||
| /* Page fault. */ | /* Page fault. */ | ||||
| case FAULT_ALIGN: | case FAULT_ALIGN: | ||||
| /* Translation Fault (L1) */ | |||||
andrew: No need for a `FALLTHROUGH` comment when there is no code. | |||||
Not Done Inline ActionsOK. The style is a bit unclear on this. graeme.jenkinson_cl.cam.ac.uk: OK. The style is a bit unclear on this. | |||||
| case FAULT_TRAN_L1: | |||||
| /* Translation Fault (L2) */ | |||||
| case FAULT_TRAN_L2: | |||||
| /* Flag a bad address. */ | /* Flag a bad address. */ | ||||
| cpu_core[curcpu].cpuc_dtrace_flags |= CPU_DTRACE_BADADDR; | cpu_core[curcpu].cpuc_dtrace_flags |= CPU_DTRACE_BADADDR; | ||||
| cpu_core[curcpu].cpuc_dtrace_illval = 0; | cpu_core[curcpu].cpuc_dtrace_illval = 0; | ||||
| /* | /* | ||||
| * Offset the instruction pointer to the instruction | * Offset the instruction pointer to the instruction | ||||
| * following the one causing the fault. | * following the one causing the fault. | ||||
| */ | */ | ||||
| ▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines | |||||
No need for a FALLTHROUGH comment when there is no code.