Changeset View
Changeset View
Standalone View
Standalone View
sys/compat/linuxkpi/common/include/linux/font.h
- This file was added.
| /* | |||||
| * SPDX-License-Identifier: BSD-2-Clause | |||||
bzUnsubmitted Done Inline Actions
bz: - is not needed anymore | |||||
Not Done Inline ActionsAccording to style.9 the SPDX-Tag goes below the copyrights; just for the future. The copyright header should be a multi-line comment like so: /* * Copyright (c) 1984-2025 John Q. Public * * SPDX-License-Identifier: BSD-2-Clause */ bz: According to style.9 the SPDX-Tag goes below the copyrights; just for the future.
```… | |||||
| * | |||||
| * Copyright (c) 2025-2026 The FreeBSD Foundation | |||||
| * Copyright (c) 2025-2026 Jean-Sébastien Pédron <dumbbell@FreeBSD.org> | |||||
| * | |||||
| * This software was developed by Jean-Sébastien Pédron under sponsorship | |||||
| * from the FreeBSD Foundation. | |||||
| */ | |||||
Done Inline ActionsYou could use the SPDX tag here? bz: You could use the SPDX tag here? | |||||
| #ifndef _LINUXKPI_LINUX_FONT_H_ | |||||
| #define _LINUXKPI_LINUX_FONT_H_ | |||||
| #include <linux/types.h> | |||||
| struct font_desc { | |||||
| const char *name; | |||||
| const void *data; | |||||
| int idx; | |||||
| unsigned int width; | |||||
| unsigned int height; | |||||
| unsigned int charcount; | |||||
| int pref; | |||||
| }; | |||||
| static inline const struct font_desc * | |||||
| get_default_font(int xres, int yres, unsigned long *font_w, | |||||
| unsigned long *font_h) | |||||
| { | |||||
| return (NULL); | |||||
| } | |||||
| #endif | |||||
Done Inline ActionsCan we split these into two lines please? bz: Can we split these into two lines please? | |||||
Done Inline ActionsUnless order is very specific in the struct this is sillily ordered. I would probably put the *name before the *data but then the question is what is normally accessed more often? It may make sense to put the *data pointer up first; but at least keep 2/4 ints together? bz: Unless order is very specific in the struct this is sillily ordered. I would probably put the… | |||||
Done Inline ActionsI moved the name and data to the beginning. It was just the same order as Linux, but that’s ok to change it. dumbbell: I moved the name and data to the beginning. It was just the same order as Linux, but that’s ok… | |||||
Done Inline Actionsremove defined() bz: remove defined() | |||||