Changeset View
Standalone View
graphics/osgearth/Makefile
| # Created by: lbartoletti <coder@tuxfamily.org> | # Created by: lbartoletti <coder@tuxfamily.org> | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= osgearth | PORTNAME= osgearth | ||||
| PORTVERSION= 2.5 | PORTVERSION= 2.7 | ||||
mat: You should keep the DISTVERSIONPREFIX line, the `2.7` bit is a branch name, and not a tag, so… | |||||
Done Inline ActionsTIL. In fact, I have put it back in, but not sure I fully understand. I tried to read up about the GitHub download URL format, and whilst there was quite a lengthy discussion about old vs new APIs, there was not much mention of branches. So, can I please ask for an explanation of why we want the filename to be gwaldron-osgearth-osgearth-2.7_GH0.tar.gz, and what that means for branches vs tag names? woodsb02: TIL. In fact, I have put it back in, but not sure I fully understand. I tried to read up about… | |||||
Done Inline ActionsThe branch name is "2.7". When upstream commits to that branch, the branch names stays the same but the tarball changes, making checksum fail after every commit. The tag name is "osgearth-2.7". As long as the tag isn't slipped (which is very bad behaviour), the tarball is fixed. GitHub's API is really flexible. If you give it a branch name, a tag name, or a commit hash, it'll send you a tarball of that thing. There's no way to tell it which one of those you wanted (which is okay, because those names can't overlap anyway). The tarballs names look strange but that was an intentional choice to ensure that distfiles could never conflict. Does that answer the question? adamw: The branch name is "2.7". When upstream commits to that branch, the branch names stays the same… | |||||
Not Done Inline ActionsAh yes, I follow now. Sorry, it took a little while to click, but I now see that the tags/releases on the osgearth GitHub page are not labelled "2.7" but instead "osgearth-2.7", and therefore without the DISTVERSIONPREFIX it was not actually downloading the release, but the latest commit of the 2.7 branch! Thanks. Its all done, and this should be ready to commit. woodsb02: Ah yes, I follow now. Sorry, it took a little while to click, but I now see that the… | |||||
| DISTVERSIONPREFIX= ${PORTNAME}- | |||||
| PORTREVISION= 6 | |||||
| CATEGORIES= graphics geography | CATEGORIES= graphics geography | ||||
| MAINTAINER= coder@tuxfamily.org | MAINTAINER= coder@tuxfamily.org | ||||
| COMMENT= osgEarth is a C++ terrain rendering toolkit for OpenSceneGraph | COMMENT= osgEarth is a C++ terrain rendering toolkit for OpenSceneGraph | ||||
| LICENSE= LGPL3 | LICENSE= LGPL3 | ||||
| BUILD_DEPENDS= ${LOCALBASE}/bin/minizip:archivers/minizip | BUILD_DEPENDS= ${LOCALBASE}/bin/minizip:archivers/minizip | ||||
matUnsubmitted Done Inline ActionsThis should be minizip:archivers/minizip. mat: This should be `minizip:archivers/minizip`. | |||||
| LIB_DEPENDS= libosg.so:graphics/osg \ | LIB_DEPENDS= libosg.so:graphics/osg \ | ||||
| libgdal.so:graphics/gdal \ | libgdal.so:graphics/gdal \ | ||||
| libcurl.so:ftp/curl | libcurl.so:ftp/curl | ||||
| USE_GITHUB= yes | USE_GITHUB= yes | ||||
| GH_ACCOUNT= gwaldron | GH_ACCOUNT= gwaldron | ||||
| USE_LDCONFIG= YES | USE_LDCONFIG= YES | ||||
| Show All 10 Lines | |||||
You should keep the DISTVERSIONPREFIX line, the 2.7 bit is a branch name, and not a tag, so it's going to move, and by doing so, breaking this port.