Changeset View
Standalone View
sys/modules/hyperv/vmbus/Makefile
.PATH: ${SRCTOP}/sys/dev/hyperv/vmbus \ | .PATH: ${SRCTOP}/sys/dev/hyperv/vmbus \ | ||||
${SRCTOP}/sys/dev/hyperv/vmbus/${MACHINE_CPUARCH} \ | ${SRCTOP}/sys/dev/hyperv/vmbus/${MACHINE_CPUARCH} \ | ||||
${SRCTOP}/sys/dev/hyperv/vmbus/x86 | ${SRCTOP}/sys/dev/hyperv/vmbus/x86 | ||||
KMOD= hv_vmbus | KMOD= hv_vmbus | ||||
SRCS= hyperv.c \ | SRCS= hyperv.c \ | ||||
hyperv_busdma.c \ | hyperv_busdma.c \ | ||||
hyperv_machdep.c \ | hyperv_machdep.c \ | ||||
vmbus.c \ | vmbus.c \ | ||||
vmbus_br.c \ | vmbus_br.c \ | ||||
vmbus_chan.c \ | vmbus_chan.c \ | ||||
vmbus_if.c \ | vmbus_if.c \ | ||||
vmbus_res.c \ | vmbus_res.c \ | ||||
vmbus_xact.c | vmbus_xact.c | ||||
kib: So this bug was not fixed, despite discussion on the lists. | |||||
Done Inline ActionsWe are working with Hyper-V team on changing the structure definition for the schakrabarti_microsoft.com: We are working with Hyper-V team on changing the structure definition for the
hypercall… | |||||
Done Inline ActionsAlso, this is not a bug, but specific to particular compiler. As we defined same structure in Linux and it works without adding any additional flag. There is no warning during compiling time on Linux. I think FreeBSD uses clang which is stricter than the compilers other OSes use. Second, we have expressed the concerns we got from FreeBSD community about using this structure to the team who defined HyperV protocol in Microsoft. It is possible they may change it in the future protocol. For the time being to improve the tlb flush performance, we decide to still use this structure for the current patch. schakrabarti_microsoft.com: Also, this is not a bug, but specific to particular compiler. As we defined same structure in… | |||||
Done Inline ActionsLinux's gcc has this bug (or rather extension) that allows this non-standards-conforming construct to have a well-defined meaning. When using non-standards-conforming constructs, that's a bug, regardless of whether or not other compilers don't complain. The fact there's no warning on Linux carries no weight for me in this argument. imp: Linux's gcc has this bug (or rather extension) that allows this non-standards-conforming… | |||||
.if ${MACHINE_CPUARCH} != "i386" && ${MACHINE_CPUARCH} != "aarch64" | .if ${MACHINE_CPUARCH} != "i386" && ${MACHINE_CPUARCH} != "aarch64" | ||||
SRCS+= vmbus_vector.S | SRCS+= vmbus_vector.S | ||||
.endif | .endif | ||||
.if ${MACHINE_CPUARCH} != "aarch64" | .if ${MACHINE_CPUARCH} != "aarch64" | ||||
SRCS+= vmbus_et.c hyperv_x86.c vmbus_x86.c | SRCS+= vmbus_et.c hyperv_x86.c vmbus_x86.c hyperv_mmu.c | ||||
.else | .else | ||||
SRC+= hyperv_aarch64.c vmbus_aarch64.c | SRC+= hyperv_aarch64.c vmbus_aarch64.c | ||||
.endif | .endif | ||||
SRCS+= acpi_if.h bus_if.h device_if.h opt_acpi.h pci_if.h pcib_if.h vmbus_if.h | SRCS+= acpi_if.h bus_if.h device_if.h opt_acpi.h pci_if.h pcib_if.h vmbus_if.h | ||||
# XXX: for assym.inc | # XXX: for assym.inc | ||||
SRCS+= opt_kstack_pages.h opt_nfs.h opt_hwpmc_hooks.h | SRCS+= opt_kstack_pages.h opt_nfs.h opt_hwpmc_hooks.h | ||||
.if ${MACHINE_CPUARCH} == "i386" | .if ${MACHINE_CPUARCH} == "i386" | ||||
Show All 15 Lines |
So this bug was not fixed, despite discussion on the lists.