Page MenuHomeFreeBSD
Differential D5848 Diff 14908 sbin/savecore/savecore.c

Changeset View

Standalone View

View Options

sbin/savecore/savecore.c

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 LinesDoTextdumpFile(int fd, off_t dumpsize, off_t lasthd, char *buf,
return (0); return (0);
} }
static void static void
DoFile(const char *savedir, const char *device) DoFile(const char *savedir, const char *device)
{ {
xo_handle_t *xostdout, *xoinfo; xo_handle_t *xostdout, *xoinfo;
static char infoname[PATH_MAX], corename[PATH_MAX], linkname[PATH_MAX]; static char infoname[PATH_MAX], corename[PATH_MAX], linkname[PATH_MAX];
static char *buf = NULL; static char *buf = NULL, *temp = NULL;
struct kerneldumpheader kdhf, kdhl; struct kerneldumpheader kdhf, kdhl;
off_t mediasize, dumpsize, firsthd, lasthd; off_t mediasize, dumpsize, firsthd, lasthd;
FILE *info, *fp; FILE *info, *fp;
mode_t oumask; mode_t oumask;
int fd, fdinfo, error; int fd, fdinfo, error;
int bounds, status; int bounds, status;
u_int sectorsize, xostyle; u_int sectorsize, xostyle;
int istextdump; int istextdump;
Show All 37 Lines if (error) {
goto closefd; goto closefd;
} }
if (verbose) { if (verbose) {
printf("mediasize = %lld\n", (long long)mediasize); printf("mediasize = %lld\n", (long long)mediasize);
printf("sectorsize = %u\n", sectorsize); printf("sectorsize = %u\n", sectorsize);
} }
if (sectorsize < sizeof kdhl) {
syslog(LOG_ERR,
"Sector size is less the kernel dump header %ld",
sizeof kdhl);
rpokalaUnsubmitted
Done
Inline Actions

"sizeof(kdhl)"

style(9): "sizeof's are written with parenthesis always."

Same issue in other places too.

rpokala: "sizeof(kdhl)" style(9): "sizeof's are written with parenthesis always." Same issue in other…
goto closefd;
}
lasthd = mediasize - sectorsize; lasthd = mediasize - sectorsize;
temp = malloc(sectorsize);
if (temp == NULL) {
syslog(LOG_ERR, "error allocating memory");
return;
}
if (lseek(fd, lasthd, SEEK_SET) != lasthd || if (lseek(fd, lasthd, SEEK_SET) != lasthd ||
read(fd, &kdhl, sizeof(kdhl)) != sizeof(kdhl)) { read(fd, temp, sectorsize) != sectorsize) {
syslog(LOG_ERR, syslog(LOG_ERR,
"error reading last dump header at offset %lld in %s: %m", "error reading last dump header at offset %lld in %s: %m",
(long long)lasthd, device); (long long)lasthd, device);
goto closefd; goto closefd;
} }
memcpy(&kdhl, temp, sizeof kdhl);
istextdump = 0; istextdump = 0;
if (strncmp(kdhl.magic, TEXTDUMPMAGIC, sizeof kdhl) == 0) { if (strncmp(kdhl.magic, TEXTDUMPMAGIC, sizeof kdhl) == 0) {
if (verbose) if (verbose)
printf("textdump magic on last dump header on %s\n", printf("textdump magic on last dump header on %s\n",
device); device);
istextdump = 1; istextdump = 1;
if (dtoh32(kdhl.version) != KERNELDUMP_TEXT_VERSION) { if (dtoh32(kdhl.version) != KERNELDUMP_TEXT_VERSION) {
syslog(LOG_ERR, syslog(LOG_ERR,
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines if (kerneldump_parity(&kdhl)) {
syslog(LOG_ERR, syslog(LOG_ERR,
"parity error on last dump header on %s", device); "parity error on last dump header on %s", device);
nerr++; nerr++;
status = STATUS_BAD; status = STATUS_BAD;
if (force == 0) if (force == 0)
goto closefd; goto closefd;
} }
dumpsize = dtoh64(kdhl.dumplength); dumpsize = dtoh64(kdhl.dumplength);
firsthd = lasthd - dumpsize - sizeof kdhf; firsthd = lasthd - dumpsize - sectorsize;
if (lseek(fd, firsthd, SEEK_SET) != firsthd || if (lseek(fd, firsthd, SEEK_SET) != firsthd ||
read(fd, &kdhf, sizeof(kdhf)) != sizeof(kdhf)) { read(fd, temp, sectorsize) != sectorsize) {
syslog(LOG_ERR, syslog(LOG_ERR,
"error reading first dump header at offset %lld in %s: %m", "error reading first dump header at offset %lld in %s: %m",
(long long)firsthd, device); (long long)firsthd, device);
nerr++; nerr++;
goto closefd; goto closefd;
} }
memcpy(&kdhf, temp, sizeof kdhf);
if (verbose >= 2) { if (verbose >= 2) {
printf("First dump headers:\n"); printf("First dump headers:\n");
printheader(xostdout, &kdhf, device, bounds, -1); printheader(xostdout, &kdhf, device, bounds, -1);
printf("\nLast dump headers:\n"); printf("\nLast dump headers:\n");
printheader(xostdout, &kdhl, device, bounds, -1); printheader(xostdout, &kdhl, device, bounds, -1);
printf("\n"); printf("\n");
▲ Show 20 Lines • Show All 133 Lines • ▼ Show 20 LinesDoFile(const char *savedir, const char *device)
if (verbose) if (verbose)
printf("dump saved\n"); printf("dump saved\n");
nuke: nuke:
if (!keep) { if (!keep) {
if (verbose) if (verbose)
printf("clearing dump header\n"); printf("clearing dump header\n");
memcpy(kdhl.magic, KERNELDUMPMAGIC_CLEARED, sizeof kdhl.magic); memcpy(kdhl.magic, KERNELDUMPMAGIC_CLEARED, sizeof kdhl.magic);
memcpy(temp, &kdhl, sizeof kdhl);
if (lseek(fd, lasthd, SEEK_SET) != lasthd || if (lseek(fd, lasthd, SEEK_SET) != lasthd ||
write(fd, &kdhl, sizeof(kdhl)) != sizeof(kdhl)) write(fd, temp, sectorsize) != sectorsize)
syslog(LOG_ERR, syslog(LOG_ERR,
"error while clearing the dump header: %m"); "error while clearing the dump header: %m");
} }
free(temp);
xo_close_container_h(xostdout, "crashdump"); xo_close_container_h(xostdout, "crashdump");
xo_finish_h(xostdout); xo_finish_h(xostdout);
close(fd); close(fd);
return; return;
closeall: closeall:
fclose(fp); fclose(fp);
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines