Page MenuHomeFreeBSD
Differential D37863 Diff 114514 tools/tools/git/hooks/prepare-commit-msg

Changeset View

Standalone View

View Options

tools/tools/git/hooks/prepare-commit-msg

Show All 36 Lines
# not staged, and untracked files. # not staged, and untracked files.
cat >$outfile <<EOF cat >$outfile <<EOF
$(awk '1;/^#$/{exit}' $1) $(awk '1;/^#$/{exit}' $1)
# 72 columns --| # 72 columns --|
# #
# Uncomment and complete these metadata fields, as appropriate: # Uncomment and complete these metadata fields, as appropriate:
# #
# PR: <If and which Problem Report is related.> # PR: <https://bugs.freebsd.org/###### Add more PR: lines as needed.>
grahamperrinUnsubmitted
Not Done
Inline Actions

Is it clear enough that there should be no more than one URL per line?

A committer might type something like this (not exceeding 72 characters):

PR: https://bugs.freebsd.org/###### https://bugs.freebsd.org/######

grahamperrin: Is it clear enough that there should be //no more than one URL// per line? A committer might…
grahamperrinUnsubmitted
Not Done
Inline Actions

… sorry, I could not find the related report at the time of my previous comment.

I visualise any string of two or more white space-separated URLs, on a single line, resulting in a single, invalid link in cgit.

From FreeBSD bug 266473 – cgit.freebsd.org breaks some links – seems to not recognise some types of URI delimiter (RFC 3986):

{F53896353}

grahamperrin: … sorry, I could not find the related report at the time of my previous comment. I visualise…
# Reported by: <If someone else reported the issue.> # Reported by: <If someone else reported the issue.>
# Reviewed by: <If someone else reviewed your modification.> # Reviewed by: <If someone else reviewed your modification.>
# Tested by: <If someone else tested the change.> # Tested by: <If someone else tested the change.>
# Approved by: <If you needed approval for this commit.> # Approved by: <If you needed approval for this commit.>
# Obtained from: <If the change is from a third party.> # Obtained from: <If the change is from a third party.>
# Fixes: <Short hash and title line of commit fixed by this change> # Fixes: <Short hash and title line of commit fixed by this change>
# MFC after: <N [day[s]|week[s]|month[s]]. Request a reminder email> # MFC after: <N [day[s]|week[s]|month[s]]. Request a reminder email>
# Relnotes: <Set to 'yes' for mention in release notes.> # Relnotes: <Set to 'yes' for mention in release notes.>
Show All 12 Lines