Differential D36052 Diff 114194 stand/efi/loader/efiserialio.c

Changeset View

Standalone View

stand/efi/loader/efiserialio.c

Context not available.

	#define COMC_TXWAIT 0x40000 /* transmit timeout */	#define COMC_TXWAIT 0x40000 /* transmit timeout */

	#ifndef COMSPEED
	#define COMSPEED 9600
	#endif

	#define PNP0501 0x501 /* 16550A-compatible COM port */	#define PNP0501 0x501 /* 16550A-compatible COM port */

	struct serial {	struct serial {
Context not available.
	if (comc_port == NULL)	if (comc_port == NULL)
	return;	return;
	}	}
	comc_port->baudrate = COMSPEED;	/*
	tsoomeUnsubmitted Done Inline Actions As COMSPEED is replaced by 0, it is not used any more and can be deleted from beginning of the file. (in the future, please set up phabricator with more context, git arc can do it for you - see ./tools/tools/git). tsoome: As COMSPEED is replaced by 0, it is not used any more and can be deleted from beginning of the…
	comc_port->ioaddr = 0; /* default port */	* setting default values from firmware
	comc_port->databits = 8; /* 8,n,1 */	*/
	comc_port->parity = NoParity; /* 8,n,1 */	comc_port->baudrate = 0;
		tsoomeUnsubmitted Not Done Inline Actions Actually, I have just found an qemu-system-aarch64 varaint, which did choke on these values... I did add a change to fight with it -- after we get handle to sio, we can set the values from sio->Mode, also add defaults for timeout and receivefifodepth, so we can use those values in comc_setup() (instead of 0's). tsoome: Actually, I have just found an qemu-system-aarch64 varaint, which did choke on these values...
		schakrabarti_microsoft.comAuthorUnsubmitted Done Inline Actions Can you please share me the patch for the same, I can then test it on Hyper-V ARM64. schakrabarti_microsoft.com: Can you please share me the patch for the same, I can then test it on Hyper-V ARM64.
		tsoomeUnsubmitted Not Done Inline Actions This will take a bit of time - I'll try to pull it out tomorrow or so. tsoome: This will take a bit of time - I'll try to pull it out tomorrow or so.
	comc_port->stopbits = OneStopBit; /* 8,n,1 */	comc_port->ioaddr = 0;
		comc_port->databits = 0;
		tsoomeUnsubmitted Done Inline Actions I think, the comments is a bit misleading here; perhaps use like /* default XXX from firmware / -- we are not setting default port to 0, but we are asking to use value from firmware. Same for lines below. tsoome:* I think, the comments is a bit misleading here; perhaps use like /* default XXX from firmware…
		comc_port->parity = DefaultParity;
		comc_port->stopbits = DefaultStopBits;
	comc_port->ignore_cd = 1; /* ignore cd */	comc_port->ignore_cd = 1; /* ignore cd */
	comc_port->rtsdtr_off = 0; /* rts-dtr is on */	comc_port->rtsdtr_off = 0; /* rts-dtr is on */
	comc_port->sio = NULL;	comc_port->sio = NULL;
Context not available.