Differential D36277 Diff 111855 sys/netpfil/pf/if_pfsync.c

Changeset View

Standalone View

sys/netpfil/pf/if_pfsync.c

Context not available.
	#include <sys/mbuf.h>	#include <sys/mbuf.h>
	#include <sys/module.h>	#include <sys/module.h>
	#include <sys/mutex.h>	#include <sys/mutex.h>
		#include <sys/nv.h>
	#include <sys/priv.h>	#include <sys/priv.h>
	#include <sys/smp.h>	#include <sys/smp.h>
	#include <sys/socket.h>	#include <sys/socket.h>
		glebiusUnsubmitted Not Done Inline Actions What did bring in this requirement? glebius: What did bring in this requirement?
		email_luiz.eng.brAuthorUnsubmitted Done Inline Actions What did bring in this requirement? email_luiz.eng.br: > What did bring in this requirement?
		email_luiz.eng.brAuthorUnsubmitted Not Done Inline Actions It doesn't belong on this diff, ended up here by accident. With the IPv6 code in place, it's needed in order to have RT_DEFAULT_FIB for a in6_selectsrc_addr() call. email_luiz.eng.br: It doesn't belong on this diff, ended up here by accident. With the IPv6 code in place, it's…
Context not available.
	#include <netinet/tcp_fsm.h>	#include <netinet/tcp_fsm.h>
	#include <netinet/tcp_seq.h>	#include <netinet/tcp_seq.h>

		#include <netpfil/pf/pfsync_nv.h>

		struct pfsync_bucket;

		union inet_template {
		struct ip ipv4;
		};

	#define PFSYNC_MINPKT ( \	#define PFSYNC_MINPKT ( \
	sizeof(struct ip) + \	sizeof(union inet_template) + \
	sizeof(struct pfsync_header) + \	sizeof(struct pfsync_header) + \
	sizeof(struct pfsync_subheader) )	sizeof(struct pfsync_subheader) )

	struct pfsync_bucket;

	static int pfsync_upd_tcp(struct pf_kstate , struct pfsync_state_peer ,	static int pfsync_upd_tcp(struct pf_kstate , struct pfsync_state_peer ,
		kpUnsubmitted Not Done Inline Actions Same question here. If we change the size of pfsync_pkt we're going to be changing the on-wire protocol, and that's going to break sync between versions with and without IPv6 support. kp: Same question here. If we change the size of pfsync_pkt we're going to be changing the on-wire…
		email_luiz.eng.brAuthorUnsubmitted Not Done Inline Actions Same as the previous case, I did the change without being aware of the implications. I honestly don't have an idea on how to deal with it. I welcome any suggestions. email_luiz.eng.br: Same as the previous case, I did the change without being aware of the implications. I…
	struct pfsync_state_peer *);	struct pfsync_state_peer *);
	static int pfsync_in_clr(struct mbuf *, int, int, int);	static int pfsync_in_clr(struct mbuf *, int, int, int);
Context not available.
	struct ifnet *sc_ifp;	struct ifnet *sc_ifp;
	struct ifnet *sc_sync_if;	struct ifnet *sc_sync_if;
	struct ip_moptions sc_imo;	struct ip_moptions sc_imo;
	struct in_addr sc_sync_peer;	struct sockaddr_storage sc_sync_peer;
	uint32_t sc_flags;	uint32_t sc_flags;
	uint8_t sc_maxupdates;	uint8_t sc_maxupdates;
	struct ip sc_template;	union inet_template sc_template;
	struct mtx sc_mtx;	struct mtx sc_mtx;

	/* Queued data */	/* Queued data */
Context not available.
	static void pfsync_bulk_fail(void *);	static void pfsync_bulk_fail(void *);

	static void pfsync_detach_ifnet(struct ifnet *);	static void pfsync_detach_ifnet(struct ifnet *);

		static int pfsync_pfsyncreq_to_kstatus(struct pfsyncreq *,
		struct pfsync_kstatus *);
		static int pfsync_kstatus_to_softc(struct pfsync_kstatus *,
		struct pfsync_softc *);

	#ifdef IPSEC	#ifdef IPSEC
	static void pfsync_update_net_tdb(struct pfsync_tdb *);	static void pfsync_update_net_tdb(struct pfsync_tdb *);
	#endif	#endif
Context not available.
	return (error);	return (error);
	}	}

		#ifdef INET
	static int	static int
	pfsync_input(struct mbuf *mp, int offp __unused, int proto __unused)	pfsync_input(struct mbuf *mp, int offp __unused, int proto __unused)
	{	{
Context not available.
	m_freem(m);	m_freem(m);
	return (IPPROTO_DONE);	return (IPPROTO_DONE);
	}	}
		#endif

	static int	static int
	pfsync_in_clr(struct mbuf *m, int offset, int count, int flags)	pfsync_in_clr(struct mbuf *m, int offset, int count, int flags)
Context not available.
	struct pfsync_softc *sc = ifp->if_softc;	struct pfsync_softc *sc = ifp->if_softc;
	struct ifreq ifr = (struct ifreq )data;	struct ifreq ifr = (struct ifreq )data;
	struct pfsyncreq pfsyncr;	struct pfsyncreq pfsyncr;
		size_t nvbuflen;
	int error;	int error;
	int c;	int c;

Context not available.
	ifp->if_mtu = ifr->ifr_mtu;	ifp->if_mtu = ifr->ifr_mtu;
	break;	break;
	case SIOCGETPFSYNC:	case SIOCGETPFSYNC:
		// XXX: Already changed to match the new softc struct
		kpUnsubmitted Done Inline Actions Is this comment still relevant? kp: Is this comment still relevant?
	bzero(&pfsyncr, sizeof(pfsyncr));	bzero(&pfsyncr, sizeof(pfsyncr));
	PFSYNC_LOCK(sc);	PFSYNC_LOCK(sc);
	if (sc->sc_sync_if) {	if (sc->sc_sync_if) {
	strlcpy(pfsyncr.pfsyncr_syncdev,	strlcpy(pfsyncr.pfsyncr_syncdev,
	sc->sc_sync_if->if_xname, IFNAMSIZ);	sc->sc_sync_if->if_xname, IFNAMSIZ);
	}	}
	pfsyncr.pfsyncr_syncpeer = sc->sc_sync_peer;	pfsyncr.pfsyncr_syncpeer = ((struct sockaddr_in *)&sc->sc_sync_peer)->sin_addr;
	pfsyncr.pfsyncr_maxupdates = sc->sc_maxupdates;	pfsyncr.pfsyncr_maxupdates = sc->sc_maxupdates;
	pfsyncr.pfsyncr_defer = sc->sc_flags;	pfsyncr.pfsyncr_defer = sc->sc_flags;
	PFSYNC_UNLOCK(sc);	PFSYNC_UNLOCK(sc);
	return (copyout(&pfsyncr, ifr_data_get_ptr(ifr),	return (copyout(&pfsyncr, ifr_data_get_ptr(ifr),
	sizeof(pfsyncr)));	sizeof(pfsyncr)));

		case SIOCGETPFSYNCNV:
		{
		nvlist_t *nvl_syncpeer;
		nvlist_t *nvl = nvlist_create(0);

		if (nvl == NULL)
		return (ENOMEM);

		if (sc->sc_sync_if)
		nvlist_add_string(nvl, "syncdev", sc->sc_sync_if->if_xname);
		nvlist_add_number(nvl, "maxupdates", sc->sc_maxupdates);
		nvlist_add_number(nvl, "flags", sc->sc_flags);
		if ((nvl_syncpeer = pfsync_sockaddr_to_syncpeer_nvlist(&sc->sc_sync_peer)) != NULL)
		nvlist_add_nvlist(nvl, "syncpeer", nvl_syncpeer);

		void *packed = NULL;
		packed = nvlist_pack(nvl, &nvbuflen);
		if (packed == NULL) {
		error = nvlist_error(nvl);
		kpUnsubmitted Done Inline Actions I'd just ENOMEM here, that's by far the most likely cause anyway, and nvlist_error() isn't going to tell us that. kp: I'd just ENOMEM here, that's by far the most likely cause anyway, and nvlist_error() isn't…
		if (error == 0)
		error = EDOOFUS;
		free(packed, M_NVLIST);
		kpUnsubmitted Done Inline Actions We're leaking packed and nvl here. kp: We're leaking packed and nvl here.
		nvlist_destroy(nvl);
		return error;
		}

		if (nvbuflen > ifr->ifr_cap_nv.buf_length) {
		ifr->ifr_cap_nv.length = nvbuflen;
		ifr->ifr_cap_nv.buffer = NULL;
		free(packed, M_NVLIST);
		nvlist_destroy(nvl);
		return (EFBIG);
		}

		ifr->ifr_cap_nv.length = nvbuflen;
		error = copyout(packed, ifr->ifr_cap_nv.buffer, nvbuflen);

		nvlist_destroy(nvl);
		nvlist_destroy(nvl_syncpeer);
		free(packed, M_NVLIST);
		break;
		}

	case SIOCSETPFSYNC:	case SIOCSETPFSYNC:
	{	{
	struct in_mfilter *imf = NULL;	struct pfsync_kstatus status;
	struct ifnet *sifp;
	struct ip *ip;

	if ((error = priv_check(curthread, PRIV_NETINET_PF)) != 0)	if ((error = priv_check(curthread, PRIV_NETINET_PF)) != 0)
	return (error);	return (error);
Context not available.
	sizeof(pfsyncr))))	sizeof(pfsyncr))))
	return (error);	return (error);

	if (pfsyncr.pfsyncr_maxupdates > 255)	memset((char *)&status, 0, sizeof(struct pfsync_kstatus));
	return (EINVAL);	pfsync_pfsyncreq_to_kstatus(&pfsyncr, &status);

	if (pfsyncr.pfsyncr_syncdev[0] == 0)	error = pfsync_kstatus_to_softc(&status, sc);
	sifp = NULL;	return (error);
	else if ((sifp = ifunit_ref(pfsyncr.pfsyncr_syncdev)) == NULL)	}
	return (EINVAL);	case SIOCSETPFSYNCNV:
		{
		struct pfsync_kstatus status;
		void *data;
		nvlist_t *nvl;

	if (sifp != NULL && (	if ((error = priv_check(curthread, PRIV_NETINET_PF)) != 0)
	pfsyncr.pfsyncr_syncpeer.s_addr == 0 \|\|	return (error);
	pfsyncr.pfsyncr_syncpeer.s_addr ==	if (ifr->ifr_cap_nv.length > IFR_CAP_NV_MAXBUFSIZE)
	htonl(INADDR_PFSYNC_GROUP)))	return (EINVAL);
	imf = ip_mfilter_alloc(M_WAITOK, 0, 0);

	PFSYNC_LOCK(sc);	data = malloc(ifr->ifr_cap_nv.length, M_TEMP, M_WAITOK);
	if (pfsyncr.pfsyncr_syncpeer.s_addr == 0)
	sc->sc_sync_peer.s_addr = htonl(INADDR_PFSYNC_GROUP);
	else
	sc->sc_sync_peer.s_addr =
	pfsyncr.pfsyncr_syncpeer.s_addr;

	sc->sc_maxupdates = pfsyncr.pfsyncr_maxupdates;
	if (pfsyncr.pfsyncr_defer & PFSYNCF_DEFER) {
	sc->sc_flags \|= PFSYNCF_DEFER;
	V_pfsync_defer_ptr = pfsync_defer;
	} else {
	sc->sc_flags &= ~PFSYNCF_DEFER;
	V_pfsync_defer_ptr = NULL;
	}

	if (sifp == NULL) {	if ((error = copyin(ifr->ifr_cap_nv.buffer, data,
	if (sc->sc_sync_if)	ifr->ifr_cap_nv.length)) != 0) {
	if_rele(sc->sc_sync_if);	free(data, M_TEMP);
	sc->sc_sync_if = NULL;	return (error);
	pfsync_multicast_cleanup(sc);
	PFSYNC_UNLOCK(sc);
	break;
	}	}

	for (c = 0; c < pfsync_buckets; c++) {	if ((nvl = nvlist_unpack(data, ifr->ifr_cap_nv.length, 0)) == NULL) {
	PFSYNC_BUCKET_LOCK(&sc->sc_buckets[c]);	free(data, M_TEMP);
	if (sc->sc_buckets[c].b_len > PFSYNC_MINPKT &&	return (EINVAL);
	(sifp->if_mtu < sc->sc_ifp->if_mtu \|\|
	(sc->sc_sync_if != NULL &&
	sifp->if_mtu < sc->sc_sync_if->if_mtu) \|\|
	sifp->if_mtu < MCLBYTES - sizeof(struct ip)))
	pfsync_sendout(1, c);
	PFSYNC_BUCKET_UNLOCK(&sc->sc_buckets[c]);
	}	}

	pfsync_multicast_cleanup(sc);	memset((char *)&status, 0, sizeof(struct pfsync_kstatus));
		pfsync_nvstatus_to_kstatus(nvl, &status);

	if (sc->sc_sync_peer.s_addr == htonl(INADDR_PFSYNC_GROUP)) {	nvlist_destroy(nvl);
	error = pfsync_multicast_setup(sc, sifp, imf);	free(data, M_TEMP);
	if (error) {
	if_rele(sifp);
	ip_mfilter_free(imf);
	PFSYNC_UNLOCK(sc);
	return (error);
	}
	}
	if (sc->sc_sync_if)
	if_rele(sc->sc_sync_if);
	sc->sc_sync_if = sifp;

	ip = &sc->sc_template;
	bzero(ip, sizeof(*ip));
	ip->ip_v = IPVERSION;
	ip->ip_hl = sizeof(sc->sc_template) >> 2;
	ip->ip_tos = IPTOS_LOWDELAY;
	/* len and id are set later. */
	ip->ip_off = htons(IP_DF);
	ip->ip_ttl = PFSYNC_DFLTTL;
	ip->ip_p = IPPROTO_PFSYNC;
	ip->ip_src.s_addr = INADDR_ANY;
	ip->ip_dst.s_addr = sc->sc_sync_peer.s_addr;

	/* Request a full state table update. */
	if ((sc->sc_flags & PFSYNCF_OK) && carp_demote_adj_p)
	(*carp_demote_adj_p)(V_pfsync_carp_adj,
	"pfsync bulk start");
	sc->sc_flags &= ~PFSYNCF_OK;
	if (V_pf_status.debug >= PF_DEBUG_MISC)
	printf("pfsync: requesting bulk update\n");
	PFSYNC_UNLOCK(sc);
	PFSYNC_BUCKET_LOCK(&sc->sc_buckets[0]);
	pfsync_request_update(0, 0);
	PFSYNC_BUCKET_UNLOCK(&sc->sc_buckets[0]);
	PFSYNC_BLOCK(sc);
	sc->sc_ureq_sent = time_uptime;
	callout_reset(&sc->sc_bulkfail_tmo, 5 * hz, pfsync_bulk_fail,
	sc);
	PFSYNC_BUNLOCK(sc);

	break;	error = pfsync_kstatus_to_softc(&status, sc);
		return (error);
	}	}
	default:	default:
	return (ENOTTY);	return (ENOTTY);
		kpUnsubmitted Not Done Inline Actions We'd leak data here. Unless we failed to allocate data, in which case I'm not sure what copyin() will do. kp: We'd leak data here. Unless we failed to allocate data, in which case I'm not sure what copyin…
		email_luiz.eng.brAuthorUnsubmitted Not Done Inline Actions I am freeing data before returning now. According to `copy(9)`, "All but copystr() return EFAULT if a bad address is encountered". So if the allocation fails, copyin() will see the address NULL and return EFAULT, right? email_luiz.eng.br: I am freeing data before returning now. According to `copy(9)`, "All but copystr() return…
		kpUnsubmitted Done Inline Actions How so? It should be safe as soon as you've copied the strings out. (numbers are always copied, as are bools. Byte arrays and strings need to be copied, but always should be, because we can't reasonably rely on the lifetime of the nvlist structure). kp: How so? It should be safe as soon as you've copied the strings out. (numbers are always copied…
		email_luiz.eng.brAuthorUnsubmitted Done Inline Actions I wrote that when I still had a very poor understanding of nvlists. I removed the comment. email_luiz.eng.br: I wrote that when I still had a very poor understanding of nvlists. I removed the comment.
		kpUnsubmitted Not Done Inline Actions We should probably separate the input parsing (struct vs nvlist) from the actual pfsync configuration so we can re-use the latter for both cases. kp: We should probably separate the input parsing (struct vs nvlist) from the actual pfsync…
Context not available.
	struct pfsync_softc *sc = V_pfsyncif;	struct pfsync_softc *sc = V_pfsyncif;
	struct ifnet *ifp = sc->sc_ifp;	struct ifnet *ifp = sc->sc_ifp;
		kpUnsubmitted Not Done Inline Actions Leaks data. kp: Leaks data.
		email_luiz.eng.brAuthorUnsubmitted Not Done Inline Actions I went with freeing data right after the nvlist_destroy(), which covers this case and prevents leaking on normal execution as well. email_luiz.eng.br: I went with freeing data right after the nvlist_destroy(), which covers this case and prevents…
	struct mbuf *m;	struct mbuf *m;
	struct ip *ip;
	struct pfsync_header *ph;	struct pfsync_header *ph;
	struct pfsync_subheader *subh;	struct pfsync_subheader *subh;
	struct pf_kstate st, st_next;	struct pf_kstate st, st_next;
	struct pfsync_upd_req_item *ur;	struct pfsync_upd_req_item *ur;
	struct pfsync_bucket *b = &sc->sc_buckets[c];	struct pfsync_bucket *b = &sc->sc_buckets[c];
	int offset;	int aflen, offset;
	int q, count = 0;	int q, count = 0;

	KASSERT(sc != NULL, ("%s: null sc", __func__));	KASSERT(sc != NULL, ("%s: null sc", __func__));
Context not available.
	m->m_len = m->m_pkthdr.len = b->b_len;	m->m_len = m->m_pkthdr.len = b->b_len;

	/* build the ip header */	/* build the ip header */
	ip = (struct ip *)m->m_data;	switch (sc->sc_sync_peer.ss_family) {
	bcopy(&sc->sc_template, ip, sizeof(*ip));	#ifdef INET
	offset = sizeof(*ip);	case AF_INET:
		{
		struct ip *ip;

		ip = mtod(m, struct ip *);
		bcopy(&sc->sc_template.ipv4, ip, sizeof(*ip));
		aflen = offset = sizeof(*ip);

		ip->ip_len = htons(m->m_pkthdr.len);
		ip_fillid(ip);
		break;
		}
		#endif
		default:
		return;
		}

	ip->ip_len = htons(m->m_pkthdr.len);
	ip_fillid(ip);

	/* build the pfsync header */	/* build the pfsync header */
	ph = (struct pfsync_header *)(m->m_data + offset);	ph = (struct pfsync_header *)(m->m_data + offset);
Context not available.
	offset += sizeof(*ph);	offset += sizeof(*ph);

	ph->version = PFSYNC_VERSION;	ph->version = PFSYNC_VERSION;
	ph->len = htons(b->b_len - sizeof(*ip));	ph->len = htons(b->b_len - aflen);
	bcopy(V_pf_status.pf_chksum, ph->pfcksum, PF_MD5_DIGEST_LENGTH);	bcopy(V_pf_status.pf_chksum, ph->pfcksum, PF_MD5_DIGEST_LENGTH);

	/* walk the queues */	/* walk the queues */
Context not available.

	/* we're done, let's put it on the wire */	/* we're done, let's put it on the wire */
	if (ifp->if_bpf) {	if (ifp->if_bpf) {
	m->m_data += sizeof(*ip);	m->m_data += aflen;
	m->m_len = m->m_pkthdr.len = b->b_len - sizeof(*ip);	m->m_len = m->m_pkthdr.len = b->b_len - aflen;
	BPF_MTAP(ifp, m);	BPF_MTAP(ifp, m);
	m->m_data -= sizeof(*ip);	m->m_data -= aflen;
	m->m_len = m->m_pkthdr.len = b->b_len;	m->m_len = m->m_pkthdr.len = b->b_len;
	}	}

Context not available.
	free(pd, M_PFSYNC);	free(pd, M_PFSYNC);
	PFSYNC_BUCKET_UNLOCK(b);	PFSYNC_BUCKET_UNLOCK(b);

	ip_output(m, NULL, NULL, 0, NULL, NULL);	switch (sc->sc_sync_peer.ss_family) {
		#ifdef INET
		case AF_INET:
		ip_output(m, NULL, NULL, 0, NULL, NULL);
		break;
		#endif
		}

	pf_release_state(st);	pf_release_state(st);

Context not available.
	struct pfsync_softc *sc = arg;	struct pfsync_softc *sc = arg;
	struct pfsync_bucket *b;	struct pfsync_bucket *b;
	struct mbuf m, n;	struct mbuf m, n;
	int c;	int c, error;

	NET_EPOCH_ENTER(et);	NET_EPOCH_ENTER(et);
	CURVNET_SET(sc->sc_ifp->if_vnet);	CURVNET_SET(sc->sc_ifp->if_vnet);
Context not available.
	* own pfsync packet based on M_SKIP_FIREWALL	* own pfsync packet based on M_SKIP_FIREWALL
	* flag. This is XXX.	* flag. This is XXX.
	*/	*/
	if (m->m_flags & M_SKIP_FIREWALL)	switch (sc->sc_sync_peer.ss_family) {
	ip_output(m, NULL, NULL, 0, NULL, NULL);	#ifdef INET
	else if (ip_output(m, NULL, NULL, IP_RAWOUTPUT, &sc->sc_imo,	case AF_INET:
	NULL) == 0)	if (m->m_flags & M_SKIP_FIREWALL) {
		error = ip_output(m, NULL, NULL, 0,
		NULL, NULL);
		} else {
		error = ip_output(m, NULL, NULL,
		IP_RAWOUTPUT, &sc->sc_imo, NULL);
		}
		break;
		#endif
		}

		if (error == 0)
	V_pfsyncstats.pfsyncs_opackets++;	V_pfsyncstats.pfsyncs_opackets++;
	else	else
	V_pfsyncstats.pfsyncs_oerrors++;	V_pfsyncstats.pfsyncs_oerrors++;
Context not available.
	if (!(ifp->if_flags & IFF_MULTICAST))	if (!(ifp->if_flags & IFF_MULTICAST))
	return (EADDRNOTAVAIL);	return (EADDRNOTAVAIL);

	imo->imo_multicast_vif = -1;	switch (sc->sc_sync_peer.ss_family) {
		#ifdef INET
	if ((error = in_joingroup(ifp, &sc->sc_sync_peer, NULL,	case AF_INET:
	&imf->imf_inm)) != 0)	{
	return (error);	ip_mfilter_init(&imo->imo_head);
		imo->imo_multicast_vif = -1;
		if ((error = in_joingroup(ifp, &((struct sockaddr_in *)&sc->sc_sync_peer)->sin_addr, NULL,
		&imf->imf_inm)) != 0)
		return (error);

	ip_mfilter_init(&imo->imo_head);	ip_mfilter_insert(&imo->imo_head, imf);
	ip_mfilter_insert(&imo->imo_head, imf);	imo->imo_multicast_ifp = ifp;
	imo->imo_multicast_ifp = ifp;	imo->imo_multicast_ttl = PFSYNC_DFLTTL;
	imo->imo_multicast_ttl = PFSYNC_DFLTTL;	imo->imo_multicast_loop = 0;
	imo->imo_multicast_loop = 0;	break;
		}
		#endif
		}

	return (0);	return (0);
	}	}
Context not available.
	PFSYNC_UNLOCK(sc);	PFSYNC_UNLOCK(sc);
	}	}

		static int
		pfsync_pfsyncreq_to_kstatus(struct pfsyncreq pfsyncr, struct pfsync_kstatus status)
		{
		struct sockaddr_storage sa;
		status->maxupdates = pfsyncr->pfsyncr_maxupdates;
		status->flags = pfsyncr->pfsyncr_defer;

		strlcpy(status->syncdev, pfsyncr->pfsyncr_syncdev, IFNAMSIZ);

		memset(&sa, 0, sizeof(sa));
		if (pfsyncr->pfsyncr_syncpeer.s_addr != 0) {
		struct sockaddr_in in = (struct sockaddr_in )&sa;
		in->sin_family = AF_INET;
		in->sin_len = sizeof(*in);
		in->sin_addr.s_addr = pfsyncr->pfsyncr_syncpeer.s_addr;
		}
		status->syncpeer = sa;

		return 0;
		}

		static int
		pfsync_kstatus_to_softc(struct pfsync_kstatus status, struct pfsync_softc sc)
		{
		struct in_mfilter *imf = NULL;
		struct ifnet *sifp;
		struct ip *ip;
		int error;
		int c;

		if ((status->maxupdates < 0) \|\| (status->maxupdates > 255))
		return (EINVAL);

		if (status->syncdev[0] == '\0')
		sifp = NULL;
		else if ((sifp = ifunit_ref(status->syncdev)) == NULL)
		return (EINVAL);

		struct sockaddr_in *status_sin =
		(struct sockaddr_in *)&(status->syncpeer);
		if (sifp != NULL && (status_sin->sin_addr.s_addr == 0 \|\|
		status_sin->sin_addr.s_addr ==
		htonl(INADDR_PFSYNC_GROUP)))
		imf = ip_mfilter_alloc(M_WAITOK, 0, 0);

		PFSYNC_LOCK(sc);
		struct sockaddr_in sc_sin = (struct sockaddr_in )&sc->sc_sync_peer;
		sc_sin->sin_family = AF_INET;
		sc_sin->sin_len = sizeof(*sc_sin);
		if (status_sin->sin_addr.s_addr == 0) {
		sc_sin->sin_addr.s_addr = htonl(INADDR_PFSYNC_GROUP);
		} else {
		sc_sin->sin_addr.s_addr = status_sin->sin_addr.s_addr;
		}

		sc->sc_maxupdates = status->maxupdates;
		if (status->flags & PFSYNCF_DEFER) {
		sc->sc_flags \|= PFSYNCF_DEFER;
		V_pfsync_defer_ptr = pfsync_defer;
		} else {
		sc->sc_flags &= ~PFSYNCF_DEFER;
		V_pfsync_defer_ptr = NULL;
		}

		if (sifp == NULL) {
		if (sc->sc_sync_if)
		if_rele(sc->sc_sync_if);
		sc->sc_sync_if = NULL;
		pfsync_multicast_cleanup(sc);
		PFSYNC_UNLOCK(sc);
		return (0);
		}

		for (c = 0; c < pfsync_buckets; c++) {
		PFSYNC_BUCKET_LOCK(&sc->sc_buckets[c]);
		if (sc->sc_buckets[c].b_len > PFSYNC_MINPKT &&
		(sifp->if_mtu < sc->sc_ifp->if_mtu \|\|
		(sc->sc_sync_if != NULL &&
		sifp->if_mtu < sc->sc_sync_if->if_mtu) \|\|
		sifp->if_mtu < MCLBYTES - sizeof(struct ip)))
		pfsync_sendout(1, c);
		PFSYNC_BUCKET_UNLOCK(&sc->sc_buckets[c]);
		}

		pfsync_multicast_cleanup(sc);

		if (sc_sin->sin_addr.s_addr == htonl(INADDR_PFSYNC_GROUP)) {
		error = pfsync_multicast_setup(sc, sifp, imf);
		if (error) {
		if_rele(sifp);
		ip_mfilter_free(imf);
		PFSYNC_UNLOCK(sc);
		return (error);
		}
		}
		if (sc->sc_sync_if)
		if_rele(sc->sc_sync_if);
		sc->sc_sync_if = sifp;

		ip = &sc->sc_template.ipv4;
		bzero(ip, sizeof(*ip));
		ip->ip_v = IPVERSION;
		ip->ip_hl = sizeof(sc->sc_template.ipv4) >> 2;
		ip->ip_tos = IPTOS_LOWDELAY;
		/* len and id are set later. */
		ip->ip_off = htons(IP_DF);
		ip->ip_ttl = PFSYNC_DFLTTL;
		ip->ip_p = IPPROTO_PFSYNC;
		ip->ip_src.s_addr = INADDR_ANY;
		ip->ip_dst.s_addr = sc_sin->sin_addr.s_addr;

		/* Request a full state table update. */
		if ((sc->sc_flags & PFSYNCF_OK) && carp_demote_adj_p)
		(*carp_demote_adj_p)(V_pfsync_carp_adj,
		"pfsync bulk start");
		sc->sc_flags &= ~PFSYNCF_OK;
		if (V_pf_status.debug >= PF_DEBUG_MISC)
		printf("pfsync: requesting bulk update\n");
		PFSYNC_UNLOCK(sc);
		PFSYNC_BUCKET_LOCK(&sc->sc_buckets[0]);
		pfsync_request_update(0, 0);
		PFSYNC_BUCKET_UNLOCK(&sc->sc_buckets[0]);
		PFSYNC_BLOCK(sc);
		sc->sc_ureq_sent = time_uptime;
		callout_reset(&sc->sc_bulkfail_tmo, 5 * hz, pfsync_bulk_fail, sc);
		PFSYNC_BUNLOCK(sc);
		return (0);
		}

	static void	static void
	pfsync_pointers_init(void)	pfsync_pointers_init(void)
	{	{
Context not available.