Page MenuHomeFreeBSD
Differential D36213 Diff 110391 graphics/igt-gpu-tools/Makefile

Changeset View

Standalone View

View Options

graphics/igt-gpu-tools/Makefile

  • This file was added.
PORTNAME= igt-gpu-tools
DISTVERSION= 1.26.1266
CATEGORIES= graphics
MAINTAINER= jfree@FreeBSD.org
COMMENT= IGT gpu tools and tests
lwhsuUnsubmitted
Done
Inline Actions

Not a big issue but we usually use case sensitive FreeBSD in formal place.

lwhsu: Not a big issue but we usually use case sensitive `FreeBSD` in formal place.
WWW= https://drm.pages.freedesktop.org/igt-gpu-tools/
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/COPYING
IGNORE_FreeBSD_12= unsupported on FreeBSD versions < 13.1
jrmUnsubmitted
Not Done
Inline Actions

USES=gnome
USE_GNOME=cario

jrm: `USES=gnome` `USE_GNOME=cario`
BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}
jrmUnsubmitted
Not Done
Inline Actions

I think we need BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}. I'll make that change when I commit, if you agree.

jrm: I think we need `BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}`. I'll make that…
LIB_DEPENDS= libdrm.so:graphics/libdrm \
jrmUnsubmitted
Not Done
Inline Actions

USE_GNOME=glib20

so overall

USES=...gnome...
USE_GNOME= cairo glib20
jrm: `USE_GNOME=glib20` so overall ``` USES=...gnome... USE_GNOME= cairo glib20 ```
libdw.so:devel/elfutils \
libpciaccess.so:devel/libpciaccess \
jrmUnsubmitted
Not Done
Inline Actions
USES=...xorg
USE_XORG=pixman
jrm: ``` USES=...xorg USE_XORG=pixman ```
libudev.so:devel/libudev-devd
USES= bison gnome meson pkgconfig python shebangfix xorg
USE_GITLAB= yes
GL_SITE= https://gitlab.freedesktop.org
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.
python:3.0+ doesn't make much sense, you probably want just python ( https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n23 )

diizzy: We usually try to keep these on as few lines as possible for consistency between ports. python…
GL_ACCOUNT= drm
GL_COMMIT= 9338ab3ec085292817ab1e74d1f2fb90b6a98332
USE_GNOME= cairo glib20
USE_LDCONFIG= yes
USE_XORG= pixman
SHEBANG_FILES= scripts/code_cov_gather_on_test scripts/code_cov_parse_info
diizzyUnsubmitted
Done
Inline Actions

Just use SHEBANG_FILES= scripts/*.sh scripts/*.py

diizzy: Just use SHEBANG_FILES= scripts/*.sh scripts/*.py
jfreeAuthorUnsubmitted
Done
Inline Actions

Unfortunately, there are shell scripts in scripts/ that do not include the proper file extension.
Although lazy, SHEBANG_FILES= scripts/* was the easiest way to do this.
This shouldn't be necessary in the future when/if my patch to POSIX-ify the scripts gets committed upstream.

jfree: Unfortunately, there are shell scripts in `scripts/` that do not include the proper file…
jrmUnsubmitted
Not Done
Inline Actions

Would it be better to unconditionally install the man pages rather than have an option? It's just one small build dependency.

jrm: Would it be better to unconditionally install the man pages rather than have an option? It's…
OPTIONS_DEFINE= CHAMELIUM DOCS RUNNER TEST
OPTIONS_DEFAULT= DOCS RUNNER TEST
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.

diizzy: We usually try to keep these on as few lines as possible for consistency between ports.
OPTIONS_SUB= yes
diizzyUnsubmitted
Done
Inline Actions

Use MANPAGES instead for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L324

diizzy: Use MANPAGES instead for consistency - https://github.com/freebsd/freebsd…
CHAMELIUM_DESC= Build chamelium display tests
diizzyUnsubmitted
Done
Inline Actions

Change this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L487

diizzy: Change this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.
RUNNER_DESC= Build test runner
CHAMELIUM_IMPLIES= TEST
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.
No need to set DOCS , https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-options-default

diizzy: We usually try to keep these on as few lines as possible for consistency between ports. No need…
jfreeAuthorUnsubmitted
Done
Inline Actions

I adjusted the OPTIONS_DEFINE and OPTIONS_DEFAULT to be on one line as suggested.
Although it is unnecessary to include DOCS in defaults, I like the idea that someone with minimal
ports experience can look at the Makefile and know what is installed by default. This eliminates the
need to delve into the Porter's Handbook and check what the ports infrastructure deems "default".
If this is not a matter of personal preference, I will change it right away.

jfree: I adjusted the `OPTIONS_DEFINE` and `OPTIONS_DEFAULT` to be on one line as suggested. Although…
CHAMELIUM_LIB_DEPENDS= libasound.so:audio/alsa-lib \
libcurl.so:ftp/curl \
libgsl.so:math/gsl \
libxmlrpc.so:net/xmlrpc-c
CHAMELIUM_MESON_ENABLED= chamelium
DOCS_IMPLIES= TEST
DOCS_BUILD_DEPENDS= gtkdoc-mkhtml:textproc/gtk-doc
diizzyUnsubmitted
Done
Inline Actions

Why not use the default desc?

diizzy: Why not use the default desc?
DOCS_MESON_ENABLED= docs
RUNNER_IMPLIES= TEST
RUNNER_LIB_DEPENDS= libjson-c.so:devel/json-c \
liboping.so:net/liboping
RUNNER_MESON_ENABLED= runner
TEST_LIB_DEPENDS= libunwind.so:devel/libunwind
TEST_MESON_ENABLED= tests
.include <bsd.port.options.mk>
.if ${ARCH} == "amd64"
PLIST_SUB+= AMD64=""
.else
PLIST_SUB+= AMD64="@comment "
.endif
jrmUnsubmitted
Not Done
Inline Actions

Re-reading 13.13 of the Porter's Handbook, this should be IGNORE_FreeBSD_12, go after the License variables, and be set to something like

IGNRORE_FreeBSD_12= is unsupported on FreeBSD versions < 13.1.

jrm: Re-reading `13.13` of the Porter's Handbook, this should be `IGNORE_FreeBSD_12`, go after the…
.include <bsd.port.mk>