Changeset View
Standalone View
graphics/igt-gpu-tools/Makefile
- This file was added.
PORTNAME= igt-gpu-tools | |||||
DISTVERSION= 1.26.1266 | |||||
CATEGORIES= graphics | |||||
MAINTAINER= jfree@FreeBSD.org | |||||
COMMENT= IGT gpu tools and tests | |||||
lwhsu: Not a big issue but we usually use case sensitive `FreeBSD` in formal place. | |||||
LICENSE= MIT | |||||
LICENSE_FILE= ${WRKSRC}/COPYING | |||||
IGNORE_FreeBSD_12= unsupported on FreeBSD versions < 13.1 | |||||
Not Done Inline ActionsUSES=gnome jrm: `USES=gnome`
`USE_GNOME=cario` | |||||
BUILD_DEPENDS= rst2man:textproc/py-docutils | |||||
jrmUnsubmitted Not Done Inline ActionsI think we need BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}. I'll make that change when I commit, if you agree. jrm: I think we need `BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}`. I'll make that… | |||||
LIB_DEPENDS= libdrm.so:graphics/libdrm \ | |||||
Not Done Inline ActionsUSE_GNOME=glib20 so overall USES=...gnome... USE_GNOME= cairo glib20 jrm: `USE_GNOME=glib20`
so overall
```
USES=...gnome...
USE_GNOME= cairo glib20
``` | |||||
libdw.so:devel/elfutils \ | |||||
libpciaccess.so:devel/libpciaccess \ | |||||
Not Done Inline ActionsUSES=...xorg USE_XORG=pixman jrm: ```
USES=...xorg
USE_XORG=pixman
``` | |||||
libudev.so:devel/libudev-devd | |||||
USES= bison gnome meson pkgconfig python shebangfix xorg | |||||
USE_GITLAB= yes | |||||
GL_SITE= https://gitlab.freedesktop.org | |||||
Done Inline ActionsWe usually try to keep these on as few lines as possible for consistency between ports. diizzy: We usually try to keep these on as few lines as possible for consistency between ports.
python… | |||||
GL_ACCOUNT= drm | |||||
GL_COMMIT= 9338ab3ec085292817ab1e74d1f2fb90b6a98332 | |||||
USE_GNOME= cairo glib20 | |||||
USE_LDCONFIG= yes | |||||
USE_XORG= pixman | |||||
SHEBANG_FILES= scripts/code_cov_gather_on_test scripts/code_cov_parse_info | |||||
Done Inline ActionsJust use SHEBANG_FILES= scripts/*.sh scripts/*.py diizzy: Just use SHEBANG_FILES= scripts/*.sh scripts/*.py | |||||
Done Inline ActionsUnfortunately, there are shell scripts in scripts/ that do not include the proper file extension. jfree: Unfortunately, there are shell scripts in `scripts/` that do not include the proper file… | |||||
Not Done Inline ActionsWould it be better to unconditionally install the man pages rather than have an option? It's just one small build dependency. jrm: Would it be better to unconditionally install the man pages rather than have an option? It's… | |||||
OPTIONS_DEFINE= CHAMELIUM DOCS RUNNER TEST | |||||
OPTIONS_DEFAULT= DOCS RUNNER TEST | |||||
Done Inline ActionsWe usually try to keep these on as few lines as possible for consistency between ports. diizzy: We usually try to keep these on as few lines as possible for consistency between ports. | |||||
OPTIONS_SUB= yes | |||||
Done Inline ActionsUse MANPAGES instead for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L324 diizzy: Use MANPAGES instead for consistency - https://github.com/freebsd/freebsd… | |||||
CHAMELIUM_DESC= Build chamelium display tests | |||||
Done Inline ActionsChange this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L487 diizzy: Change this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd. | |||||
RUNNER_DESC= Build test runner | |||||
CHAMELIUM_IMPLIES= TEST | |||||
Done Inline ActionsWe usually try to keep these on as few lines as possible for consistency between ports. diizzy: We usually try to keep these on as few lines as possible for consistency between ports.
No need… | |||||
Done Inline ActionsI adjusted the OPTIONS_DEFINE and OPTIONS_DEFAULT to be on one line as suggested. jfree: I adjusted the `OPTIONS_DEFINE` and `OPTIONS_DEFAULT` to be on one line as suggested.
Although… | |||||
CHAMELIUM_LIB_DEPENDS= libasound.so:audio/alsa-lib \ | |||||
libcurl.so:ftp/curl \ | |||||
libgsl.so:math/gsl \ | |||||
libxmlrpc.so:net/xmlrpc-c | |||||
CHAMELIUM_MESON_ENABLED= chamelium | |||||
DOCS_IMPLIES= TEST | |||||
DOCS_BUILD_DEPENDS= gtkdoc-mkhtml:textproc/gtk-doc | |||||
Done Inline ActionsWhy not use the default desc? diizzy: Why not use the default desc?
| |||||
DOCS_MESON_ENABLED= docs | |||||
RUNNER_IMPLIES= TEST | |||||
RUNNER_LIB_DEPENDS= libjson-c.so:devel/json-c \ | |||||
liboping.so:net/liboping | |||||
RUNNER_MESON_ENABLED= runner | |||||
TEST_LIB_DEPENDS= libunwind.so:devel/libunwind | |||||
TEST_MESON_ENABLED= tests | |||||
.include <bsd.port.options.mk> | |||||
.if ${ARCH} == "amd64" | |||||
PLIST_SUB+= AMD64="" | |||||
.else | |||||
PLIST_SUB+= AMD64="@comment " | |||||
.endif | |||||
Not Done Inline ActionsRe-reading 13.13 of the Porter's Handbook, this should be IGNORE_FreeBSD_12, go after the License variables, and be set to something like IGNRORE_FreeBSD_12= is unsupported on FreeBSD versions < 13.1. jrm: Re-reading `13.13` of the Porter's Handbook, this should be `IGNORE_FreeBSD_12`, go after the… | |||||
.include <bsd.port.mk> |
Not a big issue but we usually use case sensitive FreeBSD in formal place.