Changeset View
Changeset View
Standalone View
Standalone View
Mk/Uses/lxqt.mk
Context not available. | |||||
LXQT_TRANSLATIONS="share/lxqt/translations" \ | LXQT_TRANSLATIONS="share/lxqt/translations" \ | ||||
VERSION="${PORTVERSION}" | VERSION="${PORTVERSION}" | ||||
rakuco: It's a good idea to keep this list of declarations sorted, especially as you add more… | |||||
CMAKE_ARGS+= -DCMAKE_INSTALL_MANDIR=${MANDIR} | CMAKE_ARGS+= -DCMAKE_INSTALL_MANDIR=${MANDIRS} | ||||
matUnsubmitted Not Done Inline ActionsMANDIRS contains a list of directories, for example, if a port USES=perl5: $ make -V MANDIRS /usr/local/lib/perl5/site_perl/man /usr/local/man So this feels flimsy mat: MANDIRS contains a list of directories, for example, if a port USES=perl5:
$ make -V… | |||||
rakucoUnsubmitted Not Done Inline ActionsYeah, you probably want ${MANPREFIX}/man instead. rakuco: Yeah, you probably want `${MANPREFIX}/man` instead. | |||||
# Available LXQt components are: | # Available LXQt components are: | ||||
_USE_LXQT_ALL= globalkeys libfmqt5 lxqt qterm qtxdg | _USE_LXQT_ALL= globalkeys libfmqt5 lxqt qterm qtxdg | ||||
Context not available. | |||||
Not Done Inline ActionsDo you intend to support foo_build and foo_run as component names? If so, you need to process those here too (see how bsd.qt.mk and Uses/pyqt.mk do it). rakuco: Do you intend to support `foo_build` and `foo_run` as component names? If so, you need to… | |||||
Not Done Inline ActionsI think you need .else otherwise the component will still be added to _USE_LXQT. rakuco: I think you need `.else` otherwise the component will still be added to `_USE_LXQT`. | |||||
Not Done Inline ActionsWasn't the preferred idiom .if empty(_USE_LXQT_ALL:M${comp})? rakuco: Wasn't the preferred idiom `.if empty(_USE_LXQT_ALL:M${comp})`? | |||||
Not Done Inline ActionsIf this is a variable in the CMake code, can you just pass -DCMAKE_INSTALL_MANDIR=/right/path in CMAKE_ARGS? rakuco: If this is a variable in the CMake code, can you just pass -DCMAKE_INSTALL_MANDIR=/right/path… |
It's a good idea to keep this list of declarations sorted, especially as you add more components in the future.