Page MenuHomeFreeBSD
Differential D36213 Diff 109497 graphics/igt-gpu-tools/Makefile

Changeset View

Standalone View

View Options

graphics/igt-gpu-tools/Makefile

  • This file was added.
PORTNAME= igt-gpu-tools
DISTVERSION= 1.26.1256
CATEGORIES= graphics
MAINTAINER= jfree@FreeBSD.org
COMMENT= IGT gpu tools and tests
lwhsuUnsubmitted
Done
Inline Actions

Not a big issue but we usually use case sensitive FreeBSD in formal place.

lwhsu: Not a big issue but we usually use case sensitive `FreeBSD` in formal place.
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/COPYING
LIB_DEPENDS= libcairo.so:graphics/cairo \
jrmUnsubmitted
Not Done
Inline Actions

USES=gnome
USE_GNOME=cario

jrm: `USES=gnome` `USE_GNOME=cario`
libdrm.so:graphics/libdrm \
libdw.so:devel/elfutils \
libglib-2.0.so:devel/glib20 \
jrmUnsubmitted
Not Done
Inline Actions

USE_GNOME=glib20

so overall

USES=...gnome...
USE_GNOME= cairo glib20
jrm: `USE_GNOME=glib20` so overall ``` USES=...gnome... USE_GNOME= cairo glib20 ```
jrmUnsubmitted
Not Done
Inline Actions

I think we need BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}. I'll make that change when I commit, if you agree.

jrm: I think we need `BUILD_DEPENDS= rst2man:textproc/py-docutils@${PY_FLAVOR}`. I'll make that…
libpciaccess.so:devel/libpciaccess \
libpixman-1.so:x11/pixman \
jrmUnsubmitted
Not Done
Inline Actions
USES=...xorg
USE_XORG=pixman
jrm: ``` USES=...xorg USE_XORG=pixman ```
libudev.so:devel/libudev-devd
USES= bison meson pkgconfig python shebangfix
USE_GITLAB= yes
GL_SITE= https://gitlab.freedesktop.org
GL_ACCOUNT= drm
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.
python:3.0+ doesn't make much sense, you probably want just python ( https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n23 )

diizzy: We usually try to keep these on as few lines as possible for consistency between ports. python…
GL_COMMIT= b5e2222c9a988015bdf237e6ebb9f5b6d87ac7e1
USE_LDCONFIG= yes
SHEBANG_FILES= scripts/code_cov_gather_on_test \
scripts/code_cov_parse_info
OPTIONS_DEFINE= CHAMELIUM DOCS MANPAGES RUNNER TEST VALGRIND
OPTIONS_DEFAULT= CHAMELIUM DOCS MANPAGES RUNNER TEST VALGRIND
jrmUnsubmitted
Not Done
Inline Actions

Would it be better to unconditionally install the man pages rather than have an option? It's just one small build dependency.

jrm: Would it be better to unconditionally install the man pages rather than have an option? It's…
diizzyUnsubmitted
Done
Inline Actions

Just use SHEBANG_FILES= scripts/*.sh scripts/*.py

diizzy: Just use SHEBANG_FILES= scripts/*.sh scripts/*.py
jfreeAuthorUnsubmitted
Done
Inline Actions

Unfortunately, there are shell scripts in scripts/ that do not include the proper file extension.
Although lazy, SHEBANG_FILES= scripts/* was the easiest way to do this.
This shouldn't be necessary in the future when/if my patch to POSIX-ify the scripts gets committed upstream.

jfree: Unfortunately, there are shell scripts in `scripts/` that do not include the proper file…
OPTIONS_SUB= yes
CHAMELIUM_DESC= Build chamelium display tests
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.

diizzy: We usually try to keep these on as few lines as possible for consistency between ports.
RUNNER_DESC= Build test runner
VALGRIND_DESC= Build with support for valgrind annotations
diizzyUnsubmitted
Done
Inline Actions

Use MANPAGES instead for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L324

diizzy: Use MANPAGES instead for consistency - https://github.com/freebsd/freebsd…
CHAMELIUM_IMPLIES= TEST
diizzyUnsubmitted
Done
Inline Actions

Change this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.options.desc.mk#L487

diizzy: Change this to TEST for consistency - https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.
CHAMELIUM_LIB_DEPENDS= libasound.so:audio/alsa-lib \
libcurl.so:ftp/curl \
libgsl.so:math/gsl \
diizzyUnsubmitted
Done
Inline Actions

We usually try to keep these on as few lines as possible for consistency between ports.
No need to set DOCS , https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-options-default

diizzy: We usually try to keep these on as few lines as possible for consistency between ports. No need…
jfreeAuthorUnsubmitted
Done
Inline Actions

I adjusted the OPTIONS_DEFINE and OPTIONS_DEFAULT to be on one line as suggested.
Although it is unnecessary to include DOCS in defaults, I like the idea that someone with minimal
ports experience can look at the Makefile and know what is installed by default. This eliminates the
need to delve into the Porter's Handbook and check what the ports infrastructure deems "default".
If this is not a matter of personal preference, I will change it right away.

jfree: I adjusted the `OPTIONS_DEFINE` and `OPTIONS_DEFAULT` to be on one line as suggested. Although…
libxmlrpc.so:net/xmlrpc-c
CHAMELIUM_MESON_ENABLED=chamelium
DOCS_IMPLIES= TEST
DOCS_BUILD_DEPENDS= gtkdoc-mkhtml:textproc/gtk-doc
DOCS_MESON_ENABLED= docs
MANPAGES_BUILD_DEPENDS= rst2man:textproc/py-docutils
diizzyUnsubmitted
Done
Inline Actions

Why not use the default desc?

diizzy: Why not use the default desc?
MANPAGES_MESON_ENABLED= man
RUNNER_IMPLIES= TEST
RUNNER_LIB_DEPENDS= libjson-c.so:devel/json-c \
liboping.so:net/liboping
RUNNER_MESON_ENABLED= runner
TEST_LIB_DEPENDS= libunwind.so:devel/libunwind
TEST_MESON_ENABLED= tests
VALGRIND_IMPLIES= TEST
VALGRIND_BUILD_DEPENDS= valgrind:devel/valgrind
VALGRIND_RUN_DEPENDS= valgrind:devel/valgrind
VALGRIND_MESON_ENABLED= valgrind
.include <bsd.port.mk>
jrmUnsubmitted
Not Done
Inline Actions

Re-reading 13.13 of the Porter's Handbook, this should be IGNORE_FreeBSD_12, go after the License variables, and be set to something like

IGNRORE_FreeBSD_12= is unsupported on FreeBSD versions < 13.1.

jrm: Re-reading `13.13` of the Porter's Handbook, this should be `IGNORE_FreeBSD_12`, go after the…