Page MenuHomeFreeBSD
Differential D36138 Diff 109356 sys/arm64/rockchip/rk_iodomain.c

Changeset View

Standalone View

View Options

sys/arm64/rockchip/rk_iodomain.c

Context not available.
#define RK3288_GRF_IO_VSEL 0x380 #define RK3288_GRF_IO_VSEL 0x380
#define RK3399_GRF_IO_VSEL 0xe640 #define RK3399_GRF_IO_VSEL 0xe640
#define RK3399_PMUGRF_SOC_CON0 0x180 #define RK3399_PMUGRF_SOC_CON0 0x180
#define RK3568_PMUGRF_IO_VSEL0 0x0140
#define RK3568_PMUGRF_IO_VSEL1 0x0144
#define RK3568_PMUGRF_IO_VSEL2 0x0148
#define MAX_1V8 1850000
enum rk_iodomain_type {
RK3328 = 1,
RK3399,
RK3568,
};
struct rk_iodomain_supply { struct rk_iodomain_supply {
char *name; char *name;
Context not available.
int nsupply; int nsupply;
uint32_t grf_reg; uint32_t grf_reg;
void (*init)(struct rk_iodomain_softc *sc); void (*init)(struct rk_iodomain_softc *sc);
enum rk_iodomain_type type;
}; };
struct rk_iodomain_softc { struct rk_iodomain_softc {
Context not available.
.supply = rk3288_supply, .supply = rk3288_supply,
.nsupply = nitems(rk3288_supply), .nsupply = nitems(rk3288_supply),
.grf_reg = RK3288_GRF_IO_VSEL, .grf_reg = RK3288_GRF_IO_VSEL,
.type = RK3328,
}; };
static struct rk_iodomain_supply rk3399_supply[] = { static struct rk_iodomain_supply rk3399_supply[] = {
Context not available.
.supply = rk3399_supply, .supply = rk3399_supply,
.nsupply = nitems(rk3399_supply), .nsupply = nitems(rk3399_supply),
.grf_reg = RK3399_GRF_IO_VSEL, .grf_reg = RK3399_GRF_IO_VSEL,
.type = RK3399,
}; };
static struct rk_iodomain_supply rk3399_pmu_supply[] = { static struct rk_iodomain_supply rk3399_pmu_supply[] = {
Context not available.
.nsupply = nitems(rk3399_pmu_supply), .nsupply = nitems(rk3399_pmu_supply),
.grf_reg = RK3399_PMUGRF_SOC_CON0, .grf_reg = RK3399_PMUGRF_SOC_CON0,
.init = rk3399_pmu_init, .init = rk3399_pmu_init,
.type = RK3399,
};
static struct rk_iodomain_supply rk3568_pmu_supply[] = {
{"pmuio1-supply", 0},
{"pmuio2-supply", 1},
{"vccio1-supply", 1},
{"vccio2-supply", 2},
{"vccio3-supply", 3},
{"vccio4-supply", 4},
{"vccio5-supply", 5},
{"vccio6-supply", 6},
{"vccio7-supply", 7},
};
static struct rk_iodomain_conf rk3568_pmu_conf = {
.supply = rk3568_pmu_supply,
.nsupply = nitems(rk3568_pmu_supply),
.type = RK3568,
}; };
static struct ofw_compat_data compat_data[] = { static struct ofw_compat_data compat_data[] = {
{"rockchip,rk3288-io-voltage-domain", (uintptr_t)&rk3288_conf}, {"rockchip,rk3288-io-voltage-domain", (uintptr_t)&rk3288_conf},
{"rockchip,rk3399-io-voltage-domain", (uintptr_t)&rk3399_conf}, {"rockchip,rk3399-io-voltage-domain", (uintptr_t)&rk3399_conf},
{"rockchip,rk3399-pmu-io-voltage-domain", (uintptr_t)&rk3399_pmu_conf}, {"rockchip,rk3399-pmu-io-voltage-domain", (uintptr_t)&rk3399_pmu_conf},
{"rockchip,rk3568-pmu-io-voltage-domain", (uintptr_t)&rk3568_pmu_conf},
{NULL, 0} {NULL, 0}
}; };
Context not available.
(1 << 8) | (1 << (8 + 16))); /* set pmu1830_volsel */ (1 << 8) | (1 << (8 + 16))); /* set pmu1830_volsel */
} }
static void static int
rk_iodomain_set(struct rk_iodomain_softc *sc) rk_iodomain_set(struct rk_iodomain_softc *sc)
{ {
regulator_t supply; regulator_t supply;
Context not available.
int uvolt, i; int uvolt, i;
for (i = 0; i < sc->conf->nsupply; i++) { for (i = 0; i < sc->conf->nsupply; i++) {
mask |= (1 << sc->conf->supply[i].bit) << 16;
if (regulator_get_by_ofw_property(sc->dev, sc->node, if (regulator_get_by_ofw_property(sc->dev, sc->node,
sc->conf->supply[i].name, &supply) == 0) { sc->conf->supply[i].name, &supply) != 0) {
if (regulator_get_voltage(supply, &uvolt) == 0) { device_printf(sc->dev,
if (uvolt == 1800000) "Cannot get property for regulator %s\n",
reg |= (1 << sc->conf->supply[i].bit); sc->conf->supply[i].name);
else if (uvolt != 3000000) return (ENXIO);
device_printf(sc->dev, }
"%s regulator is at %duV, ignoring\n",
sc->conf->supply[i].name, uvolt); if (regulator_get_voltage(supply, &uvolt) != 0) {
} else device_printf(sc->dev,
device_printf(sc->dev, "Cannot get current " "Cannot get current voltage for regulator %s\n",
"voltage for regulator %s\n", sc->conf->supply[i].name);
sc->conf->supply[i].name); return (ENXIO);
manuUnsubmitted
Not Done
Inline Actions

As sos@ sais we should probably return ENXIO here and don't write to syscon or call the init func.

manu: As sos@ sais we should probably return ENXIO here and don't write to syscon or call the init…
} }
}
SYSCON_WRITE_4(sc->grf, sc->conf->grf_reg, reg | mask); if (sc->conf->type != RK3568) {
/* RK3328 and RK3399 iodomain */
mask |= (1 << sc->conf->supply[i].bit) << 16;
if (uvolt == 1800000)
reg |= (1 << sc->conf->supply[i].bit);
else if (uvolt != 3000000)
device_printf(sc->dev,
"%s regulator is at %duV, ignoring\n",
sc->conf->supply[i].name, uvolt);
} else {
/* RK3568 iodomain */
if (bootverbose) {
device_printf(sc->dev,
manuUnsubmitted
Not Done
Inline Actions

Not sure I understand the logic here, we only write to those registers for pmuio2-supply ?

manu: Not sure I understand the logic here, we only write to those registers for pmuio2-supply ?
ganboldAuthorUnsubmitted
Done
Inline Actions

yes

ganbold: yes
"Setting regulator %s voltage=%duV\n",
sc->conf->supply[i].name, uvolt);
}
switch(i) {
case 0: /* pmuio1 */
break;
case 1: /* pmuio2 */
SYSCON_WRITE_4(sc->grf, RK3568_PMUGRF_IO_VSEL2,
(1 << (sc->conf->supply[i].bit + 16)) |
manuUnsubmitted
Not Done
Inline Actions

Meh, I've missed this line earlier. Could you use a switch here, it would be easier to read I think.

manu: Meh, I've missed this line earlier. Could you use a switch here, it would be easier to read I…
(uvolt > MAX_1V8 ?
0 : 1 << sc->conf->supply[i].bit));
SYSCON_WRITE_4(sc->grf, RK3568_PMUGRF_IO_VSEL2,
(1 << (sc->conf->supply[i].bit + 4 + 16)) |
(uvolt > MAX_1V8 ?
1 << (sc->conf->supply[i].bit + 4) : 0));
case 3: /* vccio2 */
break;
case 2: /* vccio1 */
case 4: /* vccio3 */
case 5: /* vccio4 */
case 6: /* vccio5 */
manuUnsubmitted
Not Done
Inline Actions

sc->conf->supply[i].bit - 1
Same below.
You're not writing to the correct bit.

manu: sc->conf->supply[i].bit - 1 Same below. You're not writing to the correct bit.
case 7: /* vccio6 */
case 8: /* vccio7 */
SYSCON_WRITE_4(sc->grf, RK3568_PMUGRF_IO_VSEL0,
(1 << (sc->conf->supply[i].bit + 16)) |
(uvolt > MAX_1V8 ?
0 : 1 << sc->conf->supply[i].bit));
SYSCON_WRITE_4(sc->grf, RK3568_PMUGRF_IO_VSEL1,
(1 << (sc->conf->supply[i].bit + 16)) |
(uvolt > MAX_1V8 ?
1 << sc->conf->supply[i].bit : 0));
break;
default:
device_printf(sc->dev, "Index out of range\n");
}
}
}
if (sc->conf->type != RK3568)
SYSCON_WRITE_4(sc->grf, sc->conf->grf_reg, reg | mask);
if (sc->conf->init != NULL) if (sc->conf->init != NULL)
sc->conf->init(sc); sc->conf->init(sc);
return (0);
} }
static int static int
Context not available.
} }
sc->conf = (struct rk_iodomain_conf *)ofw_bus_search_compatible(dev, compat_data)->ocd_data; sc->conf = (struct rk_iodomain_conf *)ofw_bus_search_compatible(dev, compat_data)->ocd_data;
rk_iodomain_set(sc); rv = rk_iodomain_set(sc);
return (0); return (rv);
} }
static int static int
Context not available.