Changeset View
Changeset View
Standalone View
Standalone View
include/b64.h
- This file was added.
#define b64_ntop __b64_ntop | |||||
kib: This file lacks:
1. License preamble
2. include guards
3. DECLS guards
Also, other b64 symbols… | |||||
#define b64_pton __b64_pton | |||||
int b64_ntop(unsigned char const *, size_t, char *, size_t); | |||||
int b64_pton(char const *, unsigned char *, size_t); | |||||
int b64_pton_partial(char const *, unsigned char **, size_t); | |||||
kibUnsubmitted Not Done Inline ActionsIs this an interface we intend to support forever? From what I read so far in the patch, it is not pretty (to put it mildly) and in fact exposes some implementation details. Why not to normalize the interface to make it more in line with usual C conventions? At least, stop updating pointer in place etc, look at memcpy as the exemplar design. kib: Is this an interface we intend to support forever? From what I read so far in the patch, it is… |
This file lacks:
Also, other b64 symbols are in private namespace, while you are adding your symbol in the user namespace (note two underscores stuff)