Page MenuHomeFreeBSD
Differential D36027 Diff 108888 sys/arm64/rockchip/clk/rk3568_pmucru.c

Changeset View

Standalone View

View Options

sys/arm64/rockchip/clk/rk3568_pmucru.c

PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnull'd
\ No newline at end of property
/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (c) 2021, 2022 Soren Schmidt <sos@deepcore.dk>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $FreeBSD$
*/
andrewUnsubmitted
Not Done
Inline Actions

Not needed in files that aren't going to be merged to stable/12

andrew: Not needed in files that aren't going to be merged to `stable/12`
#include <sys/cdefs.h>
#include <sys/param.h>
#include <sys/systm.h>
#include <sys/bus.h>
#include <sys/rman.h>
#include <sys/kernel.h>
#include <sys/module.h>
#include <machine/bus.h>
#include <dev/fdt/simplebus.h>
#include <dev/ofw/ofw_bus.h>
#include <dev/ofw/ofw_bus_subr.h>
#include <dev/extres/clk/clk_div.h>
#include <dev/extres/clk/clk_fixed.h>
#include <dev/extres/clk/clk_mux.h>
#include <arm64/rockchip/clk/rk_cru.h>
#include <contrib/device-tree/include/dt-bindings/clock/rk3568-cru.h>
#define RK3568_PLLSEL_CON(x) ((x) * 0x20)
#define RK3568_CLKSEL_CON(x) ((x) * 0x4 + 0x100)
#define RK3568_CLKGATE_CON(x) ((x) * 0x4 + 0x180)
#define RK3568_SOFTRST_CON(x) ((x) * 0x4 + 0x200)
#define PNAME(_name) static const char *_name[]
/* PLL clock */
#define RK_PLL(_id, _name, _pnames, _off, _shift) \
{ \
.type = RK3328_CLK_PLL, \
.clk.pll = &(struct rk_clk_pll_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = _pnames, \
.clkdef.parent_cnt = nitems(_pnames), \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.base_offset = RK3568_PLLSEL_CON(_off), \
.mode_reg = 0x80, \
.mode_shift = _shift, \
.rates = rk3568_pll_rates, \
}, \
}
/* Composite */
#define RK_COMPOSITE(_id, _name, _pnames, _o, _ms, _mw, _ds, _dw, _go, _gw, _f) \
manuUnsubmitted
Not Done
Inline Actions

All those below aren't correct, we have proper defines in rk_cru.h
A composite clock doesn't have a gate, you're abusing the system here.
Same for every clock type that you added where there is a gate.
Please have a look at rk3399_cru.c on how to correctly define clocks.

manu: All those below aren't correct, we have proper defines in rk_cru.h A composite clock doesn't…
{ \
.type = RK_CLK_COMPOSITE, \
.clk.composite = &(struct rk_clk_composite_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = _pnames, \
.clkdef.parent_cnt = nitems(_pnames), \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.muxdiv_offset = RK3568_CLKSEL_CON(_o), \
.mux_shift = _ms, \
.mux_width = _mw, \
.div_shift = _ds, \
.div_width = _dw, \
.gate_offset = RK3568_CLKGATE_CON(_go), \
.gate_shift = _gw, \
.flags = RK_CLK_COMPOSITE_HAVE_MUX | \
RK_CLK_COMPOSITE_HAVE_GATE | _f, \
}, \
}
/* Composite no mux */
#define RK_COMPNOMUX(_id, _name, _pname, _o, _ds, _dw, _go, _gw, _f) \
{ \
.type = RK_CLK_COMPOSITE, \
.clk.composite = &(struct rk_clk_composite_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = (const char *[]){_pname}, \
.clkdef.parent_cnt = 1, \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.muxdiv_offset = RK3568_CLKSEL_CON(_o), \
.div_shift = _ds, \
.div_width = _dw, \
.gate_offset = RK3568_CLKGATE_CON(_go), \
.gate_shift = _gw, \
.flags = RK_CLK_COMPOSITE_HAVE_GATE | _f, \
}, \
}
/* Fixed factor mux/div */
#define RK_FACTOR(_id, _name, _pname, _mult, _div) \
{ \
.type = RK_CLK_FIXED, \
.clk.fixed = &(struct clk_fixed_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = (const char *[]){_pname}, \
.clkdef.parent_cnt = 1, \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.mult = _mult, \
.div = _div, \
}, \
}
/* Fractional */
#define RK_FRACTION(_id, _name, _pname, _o, _go, _gw, _f) \
{ \
.type = RK_CLK_FRACT, \
.clk.fract = &(struct rk_clk_fract_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = (const char *[]){_pname}, \
.clkdef.parent_cnt = 1, \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.offset = RK3568_CLKSEL_CON(_o), \
.gate_offset = RK3568_CLKGATE_CON(_go), \
.gate_shift = _gw, \
.flags = RK_CLK_FRACT_HAVE_GATE | _f, \
}, \
}
/* Multiplexer */
#define RK_MUX(_id, _name, _pnames, _o, _ms, _mw, _f) \
{ \
.type = RK_CLK_MUX, \
.clk.mux = &(struct rk_clk_mux_def) { \
.clkdef.id = _id, \
.clkdef.name = _name, \
.clkdef.parent_names = _pnames, \
.clkdef.parent_cnt = nitems(_pnames), \
.clkdef.flags = CLK_NODE_STATIC_STRINGS, \
.offset = RK3568_CLKSEL_CON(_o), \
.shift = _ms, \
.width = _mw, \
.mux_flags = _f, \
}, \
}
#define RK_GATE(_id, _name, _pname, _o, _s) \
{ \
.id = _id, \
.name = _name, \
.parent_name = _pname, \
.offset = RK3568_CLKGATE_CON(_o), \
.shift = _s, \
}
extern struct rk_clk_pll_rate rk3568_pll_rates[];
/* Parent clock defines */
PNAME(mux_pll_p) = { "xin24m" };
PNAME(xin24m_32k_p) = { "xin24m", "clk_rtc_32k" };
PNAME(sclk_uart0_p) = { "sclk_uart0_div", "sclk_uart0_frac", "xin24m" };
PNAME(clk_rtc32k_pmu_p) = { "clk_32k_pvtm", "xin32k", "clk_rtc32k_frac" };
PNAME(ppll_usb480m_cpll_gpll_p) = { "ppll", "usb480m", "cpll", "gpll"};
PNAME(clk_usbphy0_ref_p) = { "clk_ref24m", "xin_osc0_usbphy0_g" };
PNAME(clk_usbphy1_ref_p) = { "clk_ref24m", "xin_osc0_usbphy1_g" };
PNAME(clk_mipidsiphy0_ref_p) = { "clk_ref24m", "xin_osc0_mipidsiphy0_g" };
PNAME(clk_mipidsiphy1_ref_p) = { "clk_ref24m", "xin_osc0_mipidsiphy1_g" };
PNAME(clk_wifi_p) = { "clk_wifi_osc0", "clk_wifi_div" };
PNAME(clk_pciephy0_ref_p) = { "clk_pciephy0_osc0", "clk_pciephy0_div" };
PNAME(clk_pciephy1_ref_p) = { "clk_pciephy1_osc0", "clk_pciephy1_div" };
PNAME(clk_pciephy2_ref_p) = { "clk_pciephy2_osc0", "clk_pciephy2_div" };
PNAME(clk_hdmi_ref_p) = { "hpll", "hpll_ph0" };
PNAME(clk_pdpmu_p) = { "ppll", "gpll" };
PNAME(clk_pwm0_p) = { "xin24m", "clk_pdpmu" };
/* CLOCKS */
static struct rk_clk clks[] = {
/* External clocks */
LINK("xin24m"),
LINK("cpll"),
LINK("gpll"),
LINK("usb480m"),
LINK("clk_32k_pvtm"),
/* SRC_CLK */
RK_MUX(CLK_RTC_32K, "clk_rtc_32k", clk_rtc32k_pmu_p, 0, 6, 2, 0),
RK_MUX(0, "sclk_uart0_mux", sclk_uart0_p, 4, 10, 2, 0),
/* PLL's */
RK_PLL(PLL_PPLL, "ppll", mux_pll_p, 0, 0),
RK_PLL(PLL_HPLL, "hpll", mux_pll_p, 2, 2),
/* PD_PMU */
RK_FACTOR(0, "ppll_ph0", "ppll", 1, 2),
RK_FACTOR(0, "ppll_ph180", "ppll", 1, 2),
RK_FACTOR(0, "hpll_ph0", "hpll", 1, 2),
RK_MUX(CLK_PDPMU, "clk_pdpmu", clk_pdpmu_p, 2, 15, 1, 0),
RK_COMPNOMUX(PCLK_PDPMU, "pclk_pdpmu", "clk_pdpmu", 2, 0, 5, 0, 2, 0),
RK_COMPNOMUX(CLK_I2C0, "clk_i2c0", "clk_pdpmu", 3, 0, 7, 1, 1, 0),
RK_FRACTION(CLK_RTC32K_FRAC, "clk_rtc32k_frac", "xin24m", 1, 0, 1, 0),
RK_COMPNOMUX(XIN_OSC0_DIV, "xin_osc0_div", "xin24m", 0, 0, 5, 0, 0, 0),
RK_COMPOSITE(CLK_UART0_DIV, "sclk_uart0_div",
ppll_usb480m_cpll_gpll_p, 4, 8, 2, 0, 7, 1, 3, 0),
RK_FRACTION(CLK_UART0_FRAC, "sclk_uart0_frac",
"sclk_uart0_div", 5, 1, 4, 0),
RK_MUX(DBCLK_GPIO0, "dbclk_gpio0_c", xin24m_32k_p, 6, 15, 1, 0),
RK_COMPOSITE(CLK_PWM0, "clk_pwm0", clk_pwm0_p, 6, 7, 1, 0, 7, 1, 7, 0),
RK_COMPNOMUX(CLK_REF24M, "clk_ref24m", "clk_pdpmu", 7, 0, 6, 2, 0, 0),
RK_MUX(CLK_USBPHY0_REF, "clk_usbphy0_ref",
clk_usbphy0_ref_p, 8, 0, 1, 0),
RK_MUX(CLK_USBPHY1_REF, "clk_usbphy1_ref",
clk_usbphy1_ref_p, 8, 1, 1, 0),
RK_MUX(CLK_MIPIDSIPHY0_REF, "clk_mipidsiphy0_ref",
clk_mipidsiphy0_ref_p, 8, 2, 1, 0),
RK_MUX(CLK_MIPIDSIPHY1_REF, "clk_mipidsiphy1_ref",
clk_mipidsiphy1_ref_p, 8, 3, 1, 0),
RK_COMPNOMUX(CLK_WIFI_DIV, "clk_wifi_div",
"clk_pdpmu", 8, 8, 6, 2, 5, 0),
RK_MUX(CLK_WIFI, "clk_wifi", clk_wifi_p, 8, 15, 1, 0),
RK_COMPNOMUX(CLK_PCIEPHY0_DIV, "clk_pciephy0_div",
"ppll_ph0", 9, 0, 3, 2, 7, 0),
RK_MUX(CLK_PCIEPHY0_REF, "clk_pciephy0_ref",
clk_pciephy0_ref_p, 9, 3, 1, 0),
RK_COMPNOMUX(CLK_PCIEPHY1_DIV, "clk_pciephy1_div",
"ppll_ph0", 9, 4, 3, 2, 9, 0),
RK_MUX(CLK_PCIEPHY1_REF, "clk_pciephy1_ref",
clk_pciephy1_ref_p, 9, 7, 1, 0),
RK_COMPNOMUX(CLK_PCIEPHY2_DIV, "clk_pciephy2_div",
"ppll_ph0", 9, 8, 3, 2, 11, 0),
RK_MUX(CLK_PCIEPHY2_REF, "clk_pciephy2_ref",
clk_pciephy2_ref_p, 9, 11, 1, 0),
RK_MUX(CLK_HDMI_REF, "clk_hdmi_ref", clk_hdmi_ref_p, 8, 7, 1, 0),
};
/* GATES */
static struct rk_cru_gate gates[] = {
RK_GATE(PCLK_PMU, "pclk_pmu", "pclk_pdpmu", 0, 6),
RK_GATE(DBCLK_GPIO0, "dbclk_gpio0", "dbclk_gpio0_c", 1, 10),
RK_GATE(CLK_PMU, "clk_pmu", "xin24m", 0, 7),
RK_GATE(PCLK_I2C0, "pclk_i2c0", "pclk_pdpmu", 1, 0),
RK_GATE(PCLK_UART0, "pclk_uart0", "pclk_pdpmu", 1, 2),
RK_GATE(SCLK_UART0, "sclk_uart0", "sclk_uart0_mux", 1, 5),
RK_GATE(PCLK_GPIO0, "pclk_gpio0", "pclk_pdpmu", 1, 9),
RK_GATE(PCLK_PWM0, "pclk_pwm0", "pclk_pdpmu", 1, 6),
RK_GATE(CLK_CAPTURE_PWM0_NDFT, "clk_capture_pwm0_ndft", "xin24m", 1, 8),
RK_GATE(PCLK_PMUPVTM, "pclk_pmupvtm", "pclk_pdpmu", 1, 11),
RK_GATE(CLK_PMUPVTM, "clk_pmupvtm", "xin24m", 1, 12),
RK_GATE(CLK_CORE_PMUPVTM, "clk_core_pmupvtm", "xin24m", 1, 13),
RK_GATE(XIN_OSC0_USBPHY0_G, "xin_osc0_usbphy0_g", "xin24m", 2, 1),
RK_GATE(XIN_OSC0_USBPHY1_G, "xin_osc0_usbphy1_g", "xin24m", 2, 2),
RK_GATE(XIN_OSC0_MIPIDSIPHY0_G, "xin_osc0_mipidsiphy0_g",
"xin24m", 2, 3),
RK_GATE(XIN_OSC0_MIPIDSIPHY1_G, "xin_osc0_mipidsiphy1_g",
"xin24m", 2, 4),
RK_GATE(CLK_WIFI_OSC0, "clk_wifi_osc0", "xin24m", 2, 6),
RK_GATE(CLK_PCIEPHY0_OSC0, "clk_pciephy0_osc0", "xin24m", 2, 8),
RK_GATE(CLK_PCIEPHY1_OSC0, "clk_pciephy1_osc0", "xin24m", 2, 10),
RK_GATE(CLK_PCIEPHY2_OSC0, "clk_pciephy2_osc0", "xin24m", 2, 12),
RK_GATE(CLK_PCIE30PHY_REF_M, "clk_pcie30phy_ref_m", "ppll_ph0", 2, 13),
RK_GATE(CLK_PCIE30PHY_REF_N, "clk_pcie30phy_ref_n", "ppll_ph180", 2, 14),
RK_GATE(XIN_OSC0_EDPPHY_G, "xin_osc0_edpphy_g", "xin24m", 2, 15),
};
static int
probe(device_t dev)
{
andrewUnsubmitted
Not Done
Inline Actions

rk3568_pmucru_probe

andrew: `rk3568_pmucru_probe`
if (!ofw_bus_status_okay(dev))
return (ENXIO);
if (ofw_bus_is_compatible(dev, "rockchip,rk3568-pmucru")) {
device_set_desc(dev, "Rockchip RK3568 PMU Clock and Reset Unit");
return (BUS_PROBE_DEFAULT);
}
return (ENXIO);
}
static int
attach(device_t dev)
{
struct rk_cru_softc *sc;
sc = device_get_softc(dev);
sc->gates = gates;
sc->ngates = nitems(gates);
sc->dev = dev;
sc->clks = clks;
sc->nclks = nitems(clks);
sc->reset_offset = 0x200;
sc->reset_num = 4;
return (rk_cru_attach(dev));
}
static device_method_t methods[] = {
/* Device interface */
DEVMETHOD(device_probe, probe),
DEVMETHOD(device_attach, attach),
DEVMETHOD_END
};
static devclass_t devclass;
DEFINE_CLASS_1(rk3568_pmucru, rk3568_pmucru_driver, methods,
sizeof(struct rk_cru_softc), rk_cru_driver);
EARLY_DRIVER_MODULE(rk3568_pmucru, simplebus, rk3568_pmucru_driver,
devclass, 0, 0, BUS_PASS_BUS + BUS_PASS_ORDER_MIDDLE);