Page MenuHomeFreeBSD
Differential D4839 Diff 12070 sys/boot/efi/include/efi_nii.h

Changeset View

Standalone View

View Options

sys/boot/efi/include/efi_nii.h

Show All 20 LinesRevision history:
2000-Feb-18 M(f)J GUID updated. 2000-Feb-18 M(f)J GUID updated.
Structure order changed for machine word alignment. Structure order changed for machine word alignment.
Added StringId[4] to structure. Added StringId[4] to structure.
2000-Feb-14 M(f)J Genesis. 2000-Feb-14 M(f)J Genesis.
--*/ --*/
#define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL \ #define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL \
{ 0xE18541CD, 0xF755, 0x4f73, 0x92, 0x8D, 0x64, 0x3C, 0x8A, 0x79, 0xB2, 0x29 } { 0xE18541CD, 0xF755, 0x4f73, \
{ 0x92, 0x8D, 0x64, 0x3C, 0x8A, 0x79, 0xB2, 0x29 } }
#define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_31 \ #define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_31 \
emasteUnsubmitted
Done
Inline Actions

Looks good, but I'd suggest removing the line continuation (even though it's then longer than 80 cols) to reduce diffs with other versions of this file.

Here's NetBSD's, which seems to come via gnu-efi:

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/external/bsd/gnu-efi/dist/inc/efi_nii.h?annotate=1.1.1.1&only_with_tag=MAIN

#define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL \
    { 0xE18541CD, 0xF755, 0x4f73, {0x92, 0x8D, 0x64, 0x3C, 0x8A, 0x79, 0xB2, 0x29} }

I'd say we should follow that formatting.

emaste: Looks good, but I'd suggest removing the line continuation (even though it's then longer than…
{ 0x1ACED566, 0x76ED, 0x4218, 0xBC, 0x81, 0x76, 0x7F, 0x1F, 0x97, 0x7A, 0x89 } { 0x1ACED566, 0x76ED, 0x4218, \
{ 0xBC, 0x81, 0x76, 0x7F, 0x1F, 0x97, 0x7A, 0x89 } }
#define EFI_NETWORK_INTERFACE_IDENTIFIER_INTERFACE_REVISION 0x00010000 #define EFI_NETWORK_INTERFACE_IDENTIFIER_INTERFACE_REVISION 0x00010000
#define EFI_NETWORK_INTERFACE_IDENTIFIER_INTERFACE_REVISION_31 0x00010001 #define EFI_NETWORK_INTERFACE_IDENTIFIER_INTERFACE_REVISION_31 0x00010001
typedef enum { typedef enum {
EfiNetworkInterfaceUndi = 1 EfiNetworkInterfaceUndi = 1
} EFI_NETWORK_INTERFACE_TYPE; } EFI_NETWORK_INTERFACE_TYPE;
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines