unionfs: replace zero-length read check with KASSERT

The lower FS VOP_READDIR() shouldn't return an empty read without
setting EOF; don't try to handle this case only for non-DIAGNOSTIC
builds.

Noted by: kib
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D32629