HomeFreeBSD

vfs: fix vnlru marker handling for filtered/unfiltered cases

Description

vfs: fix vnlru marker handling for filtered/unfiltered cases

The global list has a marker with an invariant that free vnodes are
placed somewhere past that. A caller which performs filtering (like ZFS)
can move said marker all the way to the end, across free vnodes which
don't match. Then a caller which does not perform filtering will fail to
find them. This makes vn_alloc_hard sleep for 1 second instead of
reclaiming, resulting in significant stalls.

Fix the problem by requiring an explicit marker by callers which do
filtering.

As a temporary measure extend vnlru_free to restart if it fails to
reclaim anything.

Big thanks go to the reporter for testing several iterations of the
patch.

Reported by: Yamagi <lists yamagi.org>
Tested by: Yamagi <lists yamagi.org>
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D29324
Approved by: re (gjb)

(cherry picked from commit e9272225e6bed840b00eef1c817b188c172338ee)

Details

Provenance
mjgAuthored on Mar 17 2021, 9:33 PM
Reviewer
kib
Differential Revision
D29324: vfs: fix vnlru marker handling for filtered/unfiltered cases
Parents
rG4c6c8f51fdb7: base: remove if_wg(4) and associated utilities, manpage
Branches
Unknown
Tags
Unknown