HomeFreeBSD

tcp: When we have an out-of-order FIN we do want to strip off the FIN bit.

Description

tcp: When we have an out-of-order FIN we do want to strip off the FIN bit.

The last set of commits fixed both a panic (in rack) and an ACK-war (in freebsd and bbr).
However there was a missing case, i.e. where we get an out-of-order FIN by itself.
In such a case we don't want to leave the FIN bit set, otherwise we will do the
wrong thing and ack the FIN incorrectly. Instead we need to go through the
tcp_reasm() code and that way the FIN will be stripped and all will be well.

Reviewed by: mtuexen,rscheff
Sponsored by: Netflix Inc
Differential Revision: https://reviews.freebsd.org/D30497

(cherry picked from commit 8c69d988a8d32e53310c7b73ec8721b04b7249e6)

Details

Provenance
rrsAuthored on May 27 2021, 2:50 PM
tuexenCommitted on Jun 9 2021, 12:18 AM
Reviewer
rscheff
Differential Revision
D30497: tcp: When we have an out-of-order FIN we do want to strip off the FIN bit.
Parents
rG362f95f52897: tcp: Add a socket option to rack so we can test various changes to the slop…
Branches
Unknown
Tags
Unknown