HomeFreeBSD

ossl: Don't encryt/decrypt too much data for chacha20.

Description

ossl: Don't encryt/decrypt too much data for chacha20.

The loops for Chacha20 and Chacha20+Poly1305 which encrypted/decrypted
full blocks of data used the minimum of the input and output segment
lengths to determine the size of the next chunk ('todo') to pass to
Chacha20_ctr32(). However, the input and output segments could extend
past the end of the ciphertext region into the tag (e.g. if a "plain"
single mbuf contained an entire TLS record). If the length of the tag
plus the length of the last partial block together were at least as
large as a full Chacha20 block (64 bytes), then an extra block was
encrypted/decrypted overlapping with the tag. Fix this by also
capping the amount of data to encrypt/decrypt by the amount of
remaining data in the ciphertext region ('resid').

Reported by: gallatin
Reviewed by: cem, gallatin, markj
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D29517

Details

Provenance
jhbAuthored on Apr 1 2021, 10:42 PM
Reviewer
cem
Differential Revision
D29517: ossl: Don't encryt/decrypt too much data for chacha20.
Parents
R10:4e6c2a1ee9af: nfsv4 client: factor loop contents out into a separate function
Branches
Unknown
Tags
Unknown