HomeFreeBSD

file reference counts can get corrupted

Description

file reference counts can get corrupted

Callers of zfs_file_get and zfs_file_put can corrupt the reference
counts for the file structure resulting in a panic or a soft lockup.
When zfs send/recv runs, it will add a reference count to the
open file, and begin to send or recv the stream. If the file descriptor
is closed, then when dmu_recv_stream() or dmu_send() return we will
call zfs_file_put to remove the reference we placed on the file
structure. Unfortunately, because zfs_file_put() uses the file
descriptor to lookup the file structure, it may end up finding that
the file descriptor table no longer contains the file struct, thus
leaking the file structure. Or it might end up finding a file
descriptor for a different file and blindly updating its reference
counts. Other failure modes probably exists.

This change reworks the zfs_file_[get|put] interface to not rely
on the file descriptor but instead pass the zfs_file_t pointer around.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Co-authored-by: Allan Jude <allan@klarasystems.com>
Signed-off-by: George Wilson <gwilson@delphix.com>
External-issue: DLPX-76119
Closes #12299

Details

Provenance
George Wilson <george.wilson@delphix.com>Authored on Jul 11 2021, 1:00 AM
GitHub <noreply@github.com>Committed on Jul 11 2021, 1:00 AM
Parents
rG03dba7ae318e: dprintf_dnode: strcpy -> strlcpy
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG958826be7a3e: file reference counts can get corrupted (authored by George Wilson <george.wilson@delphix.com>).Jul 11 2021, 1:00 AM