HomeFreeBSD

libc/locale: Fix races between localeconv(3) and setlocale(3)

Description

libc/locale: Fix races between localeconv(3) and setlocale(3)

Each locale embeds a lazily initialized lconv which is populated by
localeconv(3) and localeconv_l(3). When setlocale(3) updates the global
locale, the lconv needs to be (lazily) reinitialized. To signal this,
we set flag variables in the locale structure. There are two problems:

  • The flags are set before the locale is fully updated, so a concurrent localeconv() call can observe partially initialized locale data.
  • No barriers ensure that localeconv() observes a fully initialized locale if a flag is set.

So, move the flag update appropriately, and use acq/rel barriers to
provide some synchronization. Note that this is inadequate in the face
of multiple concurrent calls to setlocale(3), but this is not expected
to work regardless.

Thanks to Henry Hu <henry.hu.sh@gmail.com> for providing a test case
demonstrating the race.

PR: 258360
MFC after: 3 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D31899

Details

Provenance
markjAuthored on Fri, Sep 17, 2:44 PM
Differential Revision
D31899: libc/locale: Fix races between localeconv(3) and setlocale(3)
Parents
R10:deef4b8ce8ba: readelf: document that -u / --unwind is not yet implemented
Branches
Unknown
Tags
Unknown