HomeFreeBSD

MFC jail: Handle a possible race between jail_remove(2) and fork(2)

Description

MFC jail: Handle a possible race between jail_remove(2) and fork(2)

jail_remove(2) includes a loop that sends SIGKILL to all processes
in a jail, but skips processes in PRS_NEW state. Thus it is possible
the a process in mid-fork(2) during jail removal can survive the jail
being removed.

Add a prison flag PR_REMOVE, which is checked before the new process
returns. If the jail is being removed, the process will then exit.
Also check this flag in jail_attach(2) which has a similar issue.

Approved by: so
Security: CVE-2020-25581
Security: FreeBSD-SA-21:04.jail_remove
Reported by: mjg
Approved by: kib

(cherry picked from commit cc7b73065302005ebc4a19503188c8d6d5eb923d)
(cherry picked from commit c837631bd47af73d03e3d8907f1e58b88403007c)

Details

Provenance
jamieAuthored on Feb 16 2021, 7:19 PM
markjCommitted on Feb 24 2021, 1:34 AM
Parents
rG95f9e56d8429: Add UPDATING entry and bump version
Branches
Unknown
Tags
Unknown