HomeFreeBSD

tcp: Incorrect KASSERT causes a panic in rack

Description

tcp: Incorrect KASSERT causes a panic in rack

Skyzall found an interesting panic in rack. When a SYN and FIN are
both sent together a KASSERT gets tripped where it is validating that
a mbuf pointer is in the sendmap. But a SYN and FIN often will not
have a mbuf pointer. So the fix is two fold a) make sure that the
SYN and FIN split the right way when cloning an RSM SYN on left
edge and FIN on right. And also make sure the KASSERT properly
accounts for the case that we have a SYN or FIN so we don't
panic.

Reviewed by: mtuexen
Sponsored by: Netflix Inc.
Differential Revision: https://reviews.freebsd.org/D30241

(cherry picked from commit 02cffbc2507e83944b0c29d69d6ddf26c9386d54)

Details

Provenance
rrsAuthored on May 13 2021, 11:36 AM
tuexenCommitted on Jun 9 2021, 12:05 AM
Differential Revision
D30241: syzcaller found an interesting Invariant crash
Parents
rG821543e7834b: mod_cc: cross reference CC modules consistently
Branches
Unknown
Tags
Unknown