Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F157615356
D56876.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D56876.id.diff
View Options
diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c
--- a/sys/dev/acpica/acpi_spmc.c
+++ b/sys/dev/acpica/acpi_spmc.c
@@ -448,7 +448,7 @@
device_printf(sc->dev, "DSM %s: Supported functions: %#" PRIx64 "%s\n",
dsm->name, supported_functions, buf);
- if (missing != 0) {
+ if (VERBOSE() && missing != 0) {
print_bit_field(buf, sizeof(buf), missing, "FUNC",
pbf_function_name, dsm);
device_printf(sc->dev, "DSM %s: Does not enumerate expected "
@@ -456,7 +456,7 @@
dsm->name, missing, buf);
}
- if (unknown != 0) {
+ if (VERBOSE() && unknown != 0) {
print_bit_field(buf, sizeof(buf), unknown, "FUNC",
pbf_function_name, dsm);
device_printf(sc->dev, "DSM %s: Supports more functions than "
@@ -528,8 +528,13 @@
*/
revision = detail->Package.Elements[0].Integer.Value;
if (revision != 0) {
- device_printf(sc->dev, "Intel: Unknown revision %d for "
- "constraint %zu's detail package\n", revision, i);
+ /* Only print this error message once if not verbose. */
+ if (VERBOSE() || sc->constraint_count ==
+ object->Package.Count)
+ device_printf(sc->dev,
+ "Intel: Unknown revision %d for "
+ "constraint %zu's detail package\n",
+ revision, i);
sc->constraint_count--;
continue;
}
@@ -661,9 +666,11 @@
status = acpi_GetHandleInScope(sc->handle,
__DECONST(char *, constraint->name), &constraint->handle);
if (ACPI_FAILURE(status)) {
- device_printf(sc->dev,
- "Constraints: Cannot get handle for %s, ignoring\n",
- constraint->name);
+ if (VERBOSE())
+ device_printf(sc->dev,
+ "Constraints: Cannot get handle for %s, "
+ "ignoring\n",
+ constraint->name);
constraint->handle = NULL;
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, May 24, 11:09 AM (4 h, 21 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
33040000
Default Alt Text
D56876.id.diff (1 KB)
Attached To
Mode
D56876: acpi_spmc(4): Be less verbose by default
Attached
Detach File
Event Timeline
Log In to Comment