Refactor xpt_print_path() and xpt_path_string() to use the same sbuf-based
back-end. Also convert xpt_print() to use an sbuf and xpt_path_string().
These changes help reduce the mess on the console from multiple CPUs
discovering and printing devices in parallel. More work to follow,
especially with xpt_periph_announce()
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7029 Build 7209: arc lint + arc unit
Event Timeline
Comment Actions
Looks good to me. We'll have to get some runtime to see whether the extra stack space will cause any call paths that are marginal now to go over the kernel stack limit. I would hope not.
It will be nice to get everything onto one line.
Comment Actions
I have no objections, but I slightly worry about fixed 128 bytes buffer for xpt_print(). It should be enough for the vast majority of cases, but I can not say about all. Though may be it is a reason to fix those, if found.