Page MenuHomeFreeBSD

Refactor xpt_print_path() and friends
AcceptedPublic

Authored by scottl on Jan 26 2017, 1:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 19 2024, 2:10 AM
Unknown Object (File)
Dec 23 2023, 4:03 AM
Unknown Object (File)
Dec 23 2023, 1:46 AM
Unknown Object (File)
Nov 15 2023, 2:22 PM
Unknown Object (File)
Sep 10 2023, 1:30 AM
Unknown Object (File)
Aug 27 2023, 9:19 AM
Unknown Object (File)
Jul 6 2023, 2:27 PM
Unknown Object (File)
Jun 17 2023, 11:37 PM
Subscribers

Details

Reviewers
ken
mav
Summary

Refactor xpt_print_path() and xpt_path_string() to use the same sbuf-based
back-end. Also convert xpt_print() to use an sbuf and xpt_path_string().
These changes help reduce the mess on the console from multiple CPUs
discovering and printing devices in parallel. More work to follow,
especially with xpt_periph_announce()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7029
Build 7209: arc lint + arc unit

Event Timeline

scottl retitled this revision from to Refactor xpt_print_path() and friends.
scottl updated this object.
scottl edited the test plan for this revision. (Show Details)
scottl added reviewers: ken, mav.

Expose _xpt_path_string() as xpt_path_sbuf()

ken edited edge metadata.

Looks good to me. We'll have to get some runtime to see whether the extra stack space will cause any call paths that are marginal now to go over the kernel stack limit. I would hope not.

It will be nice to get everything onto one line.

This revision is now accepted and ready to land.Jan 26 2017, 4:13 PM
mav edited edge metadata.

I have no objections, but I slightly worry about fixed 128 bytes buffer for xpt_print(). It should be enough for the vast majority of cases, but I can not say about all. Though may be it is a reason to fix those, if found.