Fix ${mysql_optfile} in mysql56-server

[feld]

Summary

MySQL 5.6 used to obey mysql_optfile in rc.conf. Now it doesn't.

Looks like MySQL 5.7 doesn't obey this either, but few people run it.

[mat]

databases/mysql56-server/files/mysql-server.in

40

I think this needs to be -z "${mysql_optfile}" so that if it is empty, it still works

42

And then, if you only get here if it is empty, the ${foo=} construct is redundant.

[feld]

actually this is wrong as well. We've determined the issue is that a lot of people are running MySQL databases without any my.cnf at all, which sets certain InnoDB settings. If you try to use any my.cnf without those same settings MySQL will fail to start.

[mmokhi]

databases/mysql56-server/files/mysql-server.in

44

While we're here, What if we check existing of this file (${mysql_confdir}/my.cnf) too? just like the upper condition.
Then, if this was not existing too, leave mysql_optfile to be empty.
I guess this would be more helpful to ensure daemon never encounter to fatal error of nonexisting files.