Differential D9207
Replace dot-dot relative pathing with SRCTOP/:H make manipulation where possible Authored by ngie on Jan 17 2017, 4:28 AM. Tags None Referenced Files
Details Replace dot-dot relative pathing with SRCTOP/:H make manipulation where possible I log my buildworlds and buildkernels with script, and have noticed MFC after: 1 week Before patch: % make cleandir -j12; script all.ts time make all -j12 MK_TESTS=no
...
objcopy --strip-debug --add-gnu-debuglink=libc.so.7.debug libc.so.7.full libc.so.7
111.55 real 280.00 user 39.12 sys
% wc -c all.ts
5118811 all.ts
%
Script done, output file is all.tsAfter patch: % make cleandir -j12; script all.ts time make all -j12 MK_TESTS=no
...
objcopy --strip-debug --add-gnu-debuglink=libc.so.7.debug libc.so.7.full libc.so.7
111.70 real 279.52 user 39.50 sys
Script done, output file is all.ts
% wc -c all.ts
4836944 all.ts
%(and that savings is with just regular make output -- I'm not using -d at all)
Diff Detail
Event TimelineComment Actions Overall I like it. A few questions about :H vs ${SRCTOP}.
Comment Actions I don't want to assume I remember all the details with respect to compiling libc from a different locations, but what I recall is that it's only about building libc using a different makefile that lives in a different directory and thus having the object files go to a different object directory. Thus any mention of ${.CURDIR} had to be replaced with LIBC_SRCTOP and LIBC_SRCTOP was effectively set to ${SRCTOP}/lib/libc. As such, I think it's fine to replace ${LIBC_SRCTOP:H} with ${SRCTOP}/lib, ${LIBC_SRCTOP:H:H} with ${SRCTOP}, and consequently any paths that start with one of those. I recall that -I options needed to be tweaked, but those were prepended to CFLAGS from within the alternate makefile. My general advise therefore is to not change semantics. Make it a mechanical bug-for-bug compatible change. Comment Actions General point; using :H is preferable to ../ if only to speed up filesystem access. As several comments above have already made reasonably clear, much of the ../../ references in the FreeBSD makefiles can be replaced with SRCTOP relative references, this not only makes the intend of the makefiles clearer but also aids tree refactoring. AFAIK the prevelant use of ../.. references is largely a consequence of .CURDIR and .OBJDIR traditionally being the only known reference points. Comment Actions
I think it's probably reasonable to make this a mechanical change and not change semantics, but then I think we should either fix or drop the locale path first in an initial commit. lib/locale doesn't exist, so having it in .PATH doesn't do any good. | ||||||||||||||||||||||||||||||||||||||||||||||