Page MenuHomeFreeBSD

Allow LIB_DEPENDS to directly depend on .pc files and use pkgconf do find them
AbandonedPublic

Authored by bapt on Jan 7 2017, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 10:15 AM
Unknown Object (File)
Feb 4 2024, 7:52 PM
Unknown Object (File)
Jan 1 2024, 6:17 AM
Unknown Object (File)
Oct 24 2023, 9:50 AM
Unknown Object (File)
Oct 12 2023, 8:01 AM
Unknown Object (File)
Sep 16 2023, 7:57 AM
Unknown Object (File)
Aug 13 2023, 2:27 PM
Unknown Object (File)
Jul 4 2023, 2:06 AM

Details

Reviewers
None
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6628
Build 6846: arc lint + arc unit

Event Timeline

bapt retitled this revision from to Allow LIB_DEPENDS to directly depend on .pc files and use pkgconf do find them.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt edited edge metadata.

Add the pc files straight to depfiles

Ports using this new syntax will have to make sure they use USES=pkgconf right?

there was a question about wether we should make automatically add USES+=pkgconf if that syntax is used, or let the maintainer do it

Maybe a sanity check if the LIB_DEPENDS=pc syntax is used?

bapt edited edge metadata.

Fix small typo

bapt edited edge metadata.

Fix the sanity check

bapt edited edge metadata.

Now that pkgconf supports --path we can simplify a bit finding actual dependencies

bapt edited edge metadata.

typo

bapt edited edge metadata.

search for *.pc before *

I think it is missing checks to make sure pkgconf exists.

In the end I'm not sure this is worth it

Poudriere would need to learn about this too. https://github.com/freebsd/poudriere/blob/master/src/share/poudriere/common.sh#L4191-L4198

But yeah I'm not sure it is worth it. I'd like to see an argument for why if this is reopened.

This is not reopened, this is abandonned :)