Page MenuHomeFreeBSD
Differential D9033

Raise BLOCKIF_IOV_MAX to 128.
AbandonedPublic
Actions

Authored by jhb on Jan 3 2017, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 3:26 AM
Unknown Object (File)
Mon, Mar 25, 3:25 AM
Unknown Object (File)
Mar 10 2024, 1:38 AM
Unknown Object (File)
Mar 10 2024, 1:38 AM
Unknown Object (File)
Mar 6 2024, 2:59 PM
Unknown Object (File)
Feb 23 2024, 10:46 PM
Unknown Object (File)
Dec 27 2023, 6:52 PM
Unknown Object (File)
Dec 20 2023, 1:45 AM
View All 37 Files
Subscribers
bcran
comphuse7_gmail.com
imp
jacob_jacobmcdonald.net
jhb
mgrooms_shrew.net
rrsugawarajr_hotmail.com

Details

Reviewers
rgrimes
jceel
Group Reviewers
bhyve
Summary

Windows uses at least 67 virtio descriptors (as seen in gdb) and qemu also supports 128.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 6550

Event Timeline

jceel updated this revision to Diff 23582.Jan 3 2017, 7:40 PM
jceel retitled this revision from to Raise BLOCKIF_IOV_MAX to 128. .
jceel updated this object.
jceel edited the test plan for this revision. (Show Details)
jceel added a reviewer: grehan.
jceel set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2017, 7:41 PM
grehan edited edge metadata.Jan 3 2017, 7:44 PM

I don't think it's that simple (already tried - see r282922 and the subsequent backout in r283168)

Let me dig up the patch I have and see what else was changed.

jceel added a comment.Jan 3 2017, 7:47 PM

I'd be glad to hear what else needs to be changed - I applied that patch in freenas/os tree about a month ago and heard from several users that it fixed virtio-blk on Windows for them, but maybe they didn't push it hard enough.

grehan added a comment.Jan 3 2017, 7:50 PM

It fixes Windows but breaks other guests.

grehan mentioned this in D10581: Raise BLOCKIF_IOV_MAX to 128. Windows uses at least 67 and qemu alsosupports 128..May 24 2017, 9:52 PM
jacob_jacobmcdonald.net added a subscriber: jacob_jacobmcdonald.net.Feb 4 2018, 11:29 PM
comphuse7_gmail.com added a subscriber: comphuse7_gmail.com.Jun 9 2018, 1:26 AM
Herald added a reviewer: rgrimes. · View Herald TranscriptJun 9 2018, 1:26 AM
rgrimes edited reviewers, added: bhyve; removed: grehan, rgrimes.Jun 9 2018, 12:04 PM
Herald added a reviewer: rgrimes. · View Herald TranscriptJun 9 2018, 12:04 PM
rgrimes added a reviewer: grehan.Jun 9 2018, 12:05 PM

Unclear why phabricator does the remove of reviewers when I try to add group bhyve, restore grehan caused by that in last change.

mgrooms_shrew.net added a subscriber: mgrooms_shrew.net.Nov 6 2018, 5:57 PM
rrsugawarajr_hotmail.com added a subscriber: rrsugawarajr_hotmail.com.Jan 5 2019, 6:10 AM
rgrimes removed a reviewer: grehan.Feb 20 2019, 5:57 PM
jhb commandeered this revision.May 3 2019, 4:52 PM
jhb added a reviewer: jceel.
jhb added a subscriber: jhb.

Commandeering so I can close this. A similar fix was committed in rS347033.

Herald added a subscriber: bcran. · View Herald TranscriptMay 3 2019, 4:52 PM
jhb abandoned this revision.May 3 2019, 4:53 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 23582

View Options

usr.sbin/bhyve/block_if.h

Loading...