irc/hexchat: Fix build with libressl

[olivier]

Summary

Patch submitted directly by email to me by a user, forwarded to and validated by the port maintainer.
And during a poudriere testport, I've noticed that I had to replace an old WITH_OPENSSL_PORT.
poudriere testport logs:

• http://dev.bsdrp.net/poudriere/93i386-default/hexchat-2.12.4_1.log
• http://dev.bsdrp.net/poudriere/110amd64-default/hexchat-2.12.4_1.log

[pkubaj]

irc/hexchat/Makefile

6

Why do you bump PORTREVISION here?
Since the patch fixes build in some cases (using security/libressl*) and doesn't change anything else, it's needless.

81–82

Since 9.x is nearing EOL, I plan to remove this entry with the next update, so I believe it's not necessary to change it, however if you insist on doing this, I don't mind.

[olivier]

Remove bump PORTREVISION: It's a "Build fixes which cause a package to become compilable where it was previously failing" case.

[olivier]

irc/hexchat/Makefile

6

I'm never confident when I need to increment the PORTREVISION, then when I've got a doubt I update it.
But here I'm in the case: "Examples of changes which do not require a PORTREVISION bump. Build fixes which cause a package to become compilable where it was previously failing.", then like you say, it's useless.

81–82

I was just trying to push the more "clean" possible port for increase my chance to pass the mentors filter :-)

[brnrd]

irc/hexchat/Makefile

81–82

Setting DEFAULT_VERSIONS from a port is impoper. Use this construct in stead

.if ${SSL_DEFAULT} == base
IGNORE_FreeBSD_9=      Requires newer OpenSSL (set DEFAULT_VERSIONS+=ssl=openssl)
 .endif

irc/hexchat/files/patch-src__common__ssl.c

8

Please append the additional check rather than prepending it. Makes the diff easier to understand

-#if OPENSSL_VERSION_NUMBER < 0x10100000L
+#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

[olivier]

Comply to brnrd's advices.

[pkubaj]

irc/hexchat/Makefile

81–82

Since 9-STABLE is now EOL, this whole .if block may be removed now.

[pkubaj]

@olivier
And since it's been over two weeks, could you call it mentor timeout (similar to maintainer timeout) and just commit it? :)

[jadawin]

In D8824#186278, @pkubaj_riseup.net wrote:

@olivier
And since it's been over two weeks, could you call it mentor timeout (similar to maintainer timeout) and just commit it? :)

Nope! :)
Sorry, i was on vacations with no internet access. Oliver was aware about that and his co-mentor, too.

[oliver]

you probably wanted to add him instead of me ;)

[olivier]

Remove 9.X branch hack.

[pkubaj]

It should also be MFH'd to 2017Q1.

[brnrd]

I think this can be closed, builds OK currently with LibreSSL 2.7
https://keg.brnrd.eu/data/111amd64-default-libressl/2018-03-25_17h53m17s/logs/hexchat-2.12.4.log

[olivier]

Forgot to close this old revision.