The code was only checking for MK_GPL_DTC, which means setting both WITHOUT_FDT and WITHOUT_GPL_DTC would result in dtc being built nonetheless.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 6062
Event Timeline
Comment Actions
Is this bad? Licensing aside, dtc is useful as a cross-build and cross-development tool. We use it extensively on x86 servers that make no use of FDT.
Comment Actions
It's not bad per se; I thought this tool was only useful with the rest of the FDT code. I'm happy to drop this patch if that's not the case.
Comment Actions
FDT and DTC are different things. Please don't conflate them.
DTC is to build the compiler.
FDT is to enable support in the boot loader.
Though related, this change shouldn't be made.