Page MenuHomeFreeBSD

usr.bin/Makefile: Make dtc depend on MK_FDT
AbandonedPublic

Authored by rakuco on Nov 25 2016, 9:29 PM.

Details

Summary

The code was only checking for MK_GPL_DTC, which means setting both WITHOUT_FDT and WITHOUT_GPL_DTC would result in dtc being built nonetheless.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 6062

Event Timeline

rakuco retitled this revision from to usr.bin/Makefile: Make dtc depend on MK_FDT.Nov 25 2016, 9:29 PM
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added reviewers: theraven, imp, bdrewery.
rakuco set the repository for this revision to rS FreeBSD src repository.
rakuco updated this revision to Diff 22517.
theraven edited edge metadata.Nov 26 2016, 1:11 PM

Is this bad? Licensing aside, dtc is useful as a cross-build and cross-development tool. We use it extensively on x86 servers that make no use of FDT.

It's not bad per se; I thought this tool was only useful with the rest of the FDT code. I'm happy to drop this patch if that's not the case.

imp edited edge metadata.Nov 27 2016, 6:26 PM
imp requested changes to this revision.

FDT and DTC are different things. Please don't conflate them.

DTC is to build the compiler.
FDT is to enable support in the boot loader.

Though related, this change shouldn't be made.

This revision now requires changes to proceed.Nov 27 2016, 6:26 PM
rakuco abandoned this revision.Nov 27 2016, 8:40 PM

Thanks for the clarification, I'm closing the review.