Update graphics/exiv2 to 0.25 and switch to using cmake

[tcberner]

Summary

graphics/exiv2 is still on 0.24; 0.25 has been released in june 2015.

Also switch to using cmake during build (as it needs less patching), and is
simpler (ymmv).

[mat]

graphics/exiv2/Makefile

35–37 ↗

(On Diff #18663)

This is USES=pathfix.

[tcberner]

Use pathfix.mk -- I seem to have made an error before :)

[mat]

Looks good, make sure it builds on 9.3 and 10.1 at least :-)

[kwm]

Please be sure all the ports that depend on exiv2 build with the new version. The shlib bump already is a red flag to me.

[tcberner]

I ran:

poudriere bulk -j12-current -tC `awk -F '|' '/exiv2-0.24/{print $2}' /usr/ports/INDEX-12 | sed 's|/usr/ports/||g'

Result:

• graphics/ufraw:build call to 'abs' is ambiguous
• multimedia/kdenlive:build call to 'abs' is ambiguous
• deskutils/plasma-applet-playwolf:build call to 'abs' is ambiguous
• net/knemo-kde4:build member access into incomplete type 'struct in6_ifaddr'
• graphics/iccexamin:check-plist
• deskutils/gnome-shell-extension-backslide:checksum
• net-im/kmess-kde4:build call to 'abs' is ambiguous
• multimedia/k9copy-kde4:build call to 'abs' is ambiguous
• www/kpartsplugin:check-plist
• multimedia/subtitlecomposer-kde4:build call to 'log2' is ambiguous
• graphics/fotoxx Skipped
• ports-mgmt/kpackagekit Skipped

There were 10 errors, but none related to the exiv2 update as far as I could see.

[rakuco]

I've added some inline comments that are not blockers for landing this.

With that said, since there seem to be quite a few ports depending on this one it's probably a good idea to ask for an exp-run, and also post an updated version of this patch with all the PORTREVISION bumps in the dependent ports.

graphics/exiv2/Makefile

27–31 ↗

(On Diff #18664)

Food for thought for another commit: you can replace this whole block with CFLAGS_powerpc64= -mminimal-toc.

34 ↗

(On Diff #18664)

Personally I'm not a big fan of these sed calls, they tend to remain in the Makefile long after the things they are patching have been fixed upstream.

This is not a blocker, but I'd rather have a proper patch in files/ replacing dl with ${CMAKE_DL_LIBS} (this is also a good candidate for upstreaming).

[tcberner]

Handle the -ldl fix via a patch as suggested, and use CFLAGS_<arch>.

[tcberner]

mark stuff done.

[rakuco]

Looks good to me, but please ask for an exp-run and bump PORTREVISION in dependent ports (I usually check the "Libraries" list in the port's FreshPorts entry).

[tcberner]

Add the portrevision bumps to the ports listed on freshports.org

[mat]

In D7283#151672, @tcberner wrote:

I ran:

poudriere bulk -j12-current -tC `awk -F '|' '/exiv2-0.24/{print $2}' /usr/ports/INDEX-12 | sed 's|/usr/ports/||g'

There were 10 errors, but none related to the exiv2 update as far as I could see.

Running things on CURRENT is a nice touch, but running bulk on 10.1 or 9.3 would be more interesting, it is what people are using, and where it is most important things build.

Also, using the INDEX is good, but using grep -r graphics/exiv2 /usr/ports is better, there are ports with optional dependencies :-) (I use git for my ports work, and git grep is way faster than grep -r)