Page MenuHomeFreeBSD

Allow bigger number of packets to generate
ClosedPublic

Authored by olivier on May 19 2016, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 12:56 AM
Unknown Object (File)
Nov 25 2023, 10:05 PM
Unknown Object (File)
Sep 29 2023, 6:12 PM
Unknown Object (File)
Sep 16 2023, 10:31 AM
Unknown Object (File)
Aug 24 2023, 12:23 PM
Unknown Object (File)
Aug 7 2023, 1:34 AM
Unknown Object (File)
Apr 8 2023, 9:15 PM
Unknown Object (File)
Mar 23 2023, 6:38 AM
Subscribers

Details

Reviewers
gnn
sbruno
Summary

On 10Giga or more faster link, usage of pkt-gen ask often to generate large number of packet.
But current packet counter (-n option) is a int and core dump if we ask more than 2^31 packets.
This proposal change int to uint32_t for this counter but should it be bigger like an uint64_t ?

Test Plan

Before: pkt-gen with option "-n 4000000000" generate a core dump
After: it's works.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3820
Build 3863: arc lint + arc unit

Event Timeline

olivier retitled this revision from to Allow bigger number of packets to generate.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: gnn, sbruno.

Push it out to 64 bits please.

sbruno requested changes to this revision.May 29 2016, 5:13 PM
sbruno edited edge metadata.

Please expand npackets to a 64bit type.

This revision now requires changes to proceed.May 29 2016, 5:13 PM
olivier edited edge metadata.

Switched to uint64_t

gnn edited edge metadata.

Is this still to be committed or is it abandoned?

Still to be commited. But I'm not a src commiter (just port under mentoring), then I was not sure that just one "accepted review" is enough for allowing me to commit it directly.

By the way, this patch was accepted upstream too (https://github.com/luigirizzo/netmap/pull/211).

Cool. I'll talk with gnn and figure out whom is going to commit it.

I will test and commit this one.

This revision is now accepted and ready to land.Sep 15 2016, 5:51 PM

gnn: You want to grab this and commit it?

This has already been committed upstream and is present in HEAD.