Page MenuHomeFreeBSD
Differential D55158

sdhci_fdt_rockchip: Move ofw_bus_status_okay check
ClosedPublic
Actions

Authored by jhb on Feb 7 2026, 3:46 PM.
Tags
None
Referenced Files
F156431123: D55158.id171412.diff
Wed, May 13, 4:18 PM
Unknown Object (File)
Sun, May 10, 11:00 PM
Unknown Object (File)
Wed, May 6, 6:24 AM
Unknown Object (File)
Tue, May 5, 8:16 PM
Unknown Object (File)
Tue, May 5, 11:32 AM
Unknown Object (File)
Sun, May 3, 7:30 AM
Unknown Object (File)
Mon, Apr 27, 2:21 PM
Unknown Object (File)
Thu, Apr 23, 3:24 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
andrew
bnovkov
emaste
imp
Commits
rG2df675298a99: sdhci_fdt_rockchip: Move ofw_bus_status_okay check
rGefdd30c94e0a: sdhci_fdt_rockchip: Move ofw_bus_status_okay check
Summary

This fixes a warning from GCC:

sys/dev/sdhci/sdhci_fdt_rockchip.c: In function 'sdhci_fdt_rockchip_probe':
sys/dev/sdhci/sdhci_fdt_rockchip.c:120:14: error: statement will never be executed [-Werror=switch-unreachable]

120 |         if (!ofw_bus_status_okay(dev))
    |              ^~~~~~~~~~~~~~~~~~~~~~~~

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70494
Build 67377: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 7 2026, 3:46 PM
Herald added a reviewer: andrew. · View Herald TranscriptFeb 7 2026, 3:46 PM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Feb 7 2026, 3:46 PM
jhb added a parent revision: D55157: llvm: Link private LLVM libraries against compiler_rt for aarch64.
jhb added a child revision: D55159: sdhci_fdt_rockchip: Don't return 0 from probe routine.
Harbormaster completed remote builds in B70494: Diff 171412.Feb 7 2026, 3:47 PM
jhb added a reviewer: bnovkov.Feb 7 2026, 3:48 PM
bnovkov accepted this revision.Feb 8 2026, 4:39 PM
This revision is now accepted and ready to land.Feb 8 2026, 4:39 PM
emaste accepted this revision.Feb 9 2026, 2:32 PM
imp accepted this revision.Feb 9 2026, 3:02 PM

One of my left over action items from talking and debating Ian was to move the ok check up into ofwbus...

Closed by commit rGefdd30c94e0a: sdhci_fdt_rockchip: Move ofw_bus_status_okay check (authored by jhb). · Explain WhyFeb 9 2026, 4:28 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGefdd30c94e0a: sdhci_fdt_rockchip: Move ofw_bus_status_okay check.
jhb added a commit: rG2df675298a99: sdhci_fdt_rockchip: Move ofw_bus_status_okay check.Fri, Apr 24, 5:56 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
3 lines

Diff 171412

View Options

sys/dev/sdhci/sdhci_fdt_rockchip.c

Loading...