net/wifi-firmware-kmod: remove obsolete kernel module build code

[bz]

Summary

All supported FreeBSD versions either shipped firmware along with
source and do not need this, or they support plain firmware file
loading.

Remove the now obsolete kernel module build code to simplify the
logic in the file. Further cleanup will be done once 13.5-R is
out of support in a few months.

Sponsored by: The FreeBSD Foundation

[jrm]

net/wifi-firmware-kmod/Makefile.inc

87–89

Given that we are no longer building kernel modules, I wonder if it would be better to take the minor bits we need from Mk/Uses/kmod.mk rather than including the whole file. With USES+=kmod, we, for example, require kernel sources to be available.

If we really need .${OSVERSION} appended to PKGVERSION, you could use _OS_SUFX= .${OSVERSION}.

[bz]

net/wifi-firmware-kmod/Makefile.inc

87–89

I had planned to leave that for the further cleanup once 13.5-R is out of support, just in case and I did not want to do it all in one go.

I am also still uncertain about the magic being used to recompile certain ports automatically. I need to find the old email if it was purely based on port name including kmod or other heuristics as well. Do we have documentation for this somewhere? I found the old email again: https://lists.freebsd.org/archives/freebsd-ports/2024-December/006997.html Seems we might be good "by name only" but I'll try to confirm this with @bapt before pulling the plug...

So far no one has encountered the issue that modern firmware no longer works on an old release driver; iwlwifi keeps all the files versioned around which made it easy to update and support 3 different releases; realtek, QCA do not do it that straight forward..

[jrm]

net/wifi-firmware-kmod/Makefile.inc

87–89

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions

By appending .${OSVERSION}, an update will be triggered whenever OSVERSION increases because PKGVERSION increases.

% pkg version -t wifi-firmware-iwlwifi-kmod-ax210-20241017.1500049_2 wifi-firmware-iwlwifi-kmod-ax210-20241017.1500050_2
<

It's something that makes sense for kernel modules, but does it make sense for firemware? Do users still need to update their wifi firmware packages when the OSVERSION increases?

Caveat: I'm not certain of all the logic poudriere uses to determine whether a new package should be rebuilt.