Page MenuHomeFreeBSD

ipfilter: Add ipf_frname_vfy()
AbandonedPublic

Authored by cy on Mon, Oct 27, 11:21 PM.
Tags
None
Referenced Files
F135660657: D53388.diff
Tue, Nov 11, 4:49 PM
Unknown Object (File)
Fri, Nov 7, 5:15 PM
Unknown Object (File)
Sun, Nov 2, 8:45 AM
Unknown Object (File)
Sun, Nov 2, 8:42 AM
Unknown Object (File)
Thu, Oct 30, 3:03 PM
Unknown Object (File)
Thu, Oct 30, 3:03 PM
Unknown Object (File)
Thu, Oct 30, 9:17 AM
Unknown Object (File)
Tue, Oct 28, 5:21 AM

Details

Reviewers
emaste
markj
Summary

ipf_frname_vfy() bounds checks fr->fr_names indicies and proceeds to
copy the interface name using FR_NAME(). The ipfilter kernel module
receives the correct inputs from the ipfilter userland tools. However
a rogue actor may call the ipfilter ioctl passing out of band data.
We need to protect ourselves from this.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68153
Build 65036: arc lint + arc unit