Differential D5306

Replace several bus_alloc_resource() calls with default arguments with bus_alloc_resource_any()
ClosedPublic
Actions

Authored by jhibbits on Feb 17 2016, 3:50 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 12 2024, 2:08 AM

	Unknown Object (File)
	Mar 12 2024, 2:08 AM

	Unknown Object (File)
	Mar 12 2024, 2:05 AM

	Unknown Object (File)
	Mar 12 2024, 1:52 AM

	Unknown Object (File)
	Feb 25 2024, 6:35 PM

	Unknown Object (File)
	Jan 5 2024, 2:17 AM

	Unknown Object (File)
	Jan 3 2024, 3:24 PM

	Unknown Object (File)
	Dec 20 2023, 1:19 AM

View All 61 Files

Subscribers

Details

Reviewers

Group Reviewers

Intel Networking

Commits

rS295790: Replace several bus_alloc_resource() calls using default arguments with…

Summary

Related to D5255 and D4544. Since these calls only use default
arguments, bus_alloc_resource_any() is the right call.

Test Plan

make universe

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits updated this revision to Diff 13380.Feb 17 2016, 3:50 AM

jhibbits retitled this revision from to Replace several bus_alloc_resource() calls with default arguments with bus_alloc_resource_any().

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added a reviewer: jhb.

Herald added a reviewer: Intel Networking. · View Herald TranscriptFeb 17 2016, 3:50 AM

Herald added a subscriber: imp. · View Herald Transcript

This looks good to me. bus_alloc_resource_any() has been in the tree long enough that this shouldn't affect the ability of these drivers to support older releases. The bulk of them appear to be written by the vendor and committed.

Thanks for doing this cleanup...

I would also check for allocations of '0, 0, 0' as in sys/dev/cy. Those are also effectively an "any" request. All of these changes look good of course.

Closed by commit rS295790: Replace several bus_alloc_resource() calls using default arguments with… (authored by jhibbits). · Explain WhyFeb 19 2016, 3:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

arcmsr/

2 lines

cy/

10 lines

10 lines

ed/

4 lines

fb/

8 lines

fdc/

3 lines

hpt27xx/

hpt27xx_osm_bsd.c

4 lines

hptiop/

4 lines

hptmv/

2 lines

hptnr/

hptnr_osm_bsd.c

4 lines

hptrr/

hptrr_osm_bsd.c

4 lines

isci/

4 lines

ixgb/

10 lines

lmc/

8 lines

mrsas/

4 lines

mxge/

8 lines

nvme/

8 lines

quicc/

12 lines

sound/

pci/

20 lines

12 lines

8 lines

4 lines

twa/

tw_osl_freebsd.c

8 lines

tws/

4 lines

isa/

8 lines

8 lines

mips/

sibyte/

2 lines

Diff 13473

head/sys/dev/arcmsr/arcmsr.c

Loading...

head/sys/dev/cy/cy_isa.c

Loading...

head/sys/dev/cy/cy_pci.c

Loading...

head/sys/dev/ed/if_ed_pccard.c

Loading...

head/sys/dev/fb/s3_pci.c

Loading...

head/sys/dev/fdc/fdc_pccard.c

Loading...

head/sys/dev/hpt27xx/hpt27xx_osm_bsd.c

Loading...

head/sys/dev/hptiop/hptiop.c

Loading...

head/sys/dev/hptmv/entry.c

Loading...

head/sys/dev/hptnr/hptnr_osm_bsd.c

Loading...

head/sys/dev/hptrr/hptrr_osm_bsd.c

Loading...

head/sys/dev/isci/isci.c

Loading...

head/sys/dev/ixgb/if_ixgb.c

Loading...

head/sys/dev/lmc/if_lmc.c

Loading...

head/sys/dev/mrsas/mrsas.c

Loading...

head/sys/dev/mxge/if_mxge.c

Loading...

head/sys/dev/nvme/nvme_ctrlr.c

Loading...

head/sys/dev/quicc/quicc_core.c

Loading...

head/sys/dev/sound/pci/envy24.c

Loading...

head/sys/dev/sound/pci/envy24ht.c

Loading...

head/sys/dev/sound/pci/hdspe.c

Loading...

head/sys/dev/sound/pci/vibes.c

Loading...

head/sys/dev/twa/tw_osl_freebsd.c

Loading...

head/sys/dev/tws/tws.c

Loading...

head/sys/isa/isa_common.c

Loading...

head/sys/isa/vga_isa.c

Loading...

head/sys/mips/sibyte/ata_zbbus.c

Loading...