Page MenuHomeFreeBSD
Differential D5095

Fixing kbd.c bug 'OGIO_KEYMAP command does not restore priority level'
ClosedPublic
Actions

Authored by mmokhi on Jan 27 2016, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 7:38 AM
Unknown Object (File)
Oct 27 2024, 11:26 PM
Unknown Object (File)
Oct 4 2024, 7:14 PM
Unknown Object (File)
Oct 4 2024, 2:58 PM
Unknown Object (File)
Oct 4 2024, 7:24 AM
Unknown Object (File)
Oct 4 2024, 5:08 AM
Unknown Object (File)
Oct 3 2024, 9:51 PM
Unknown Object (File)
Oct 3 2024, 2:31 PM
View All 93 Files
Subscribers
cem
imp
lifanov
mmokhi
Contributor Reviews (src)

Details

Reviewers
cem
matthew
Commits
rS312352: MFC r311650
rS312351: MFC r311650
rS311650: Restore priority value for OGIO_KEYMAP
Summary

Missing call of 'splx()' before return inside 'genkbd_commonioctl()'

May cause security vuln. (thanks to CTurt@hardenedbsd )

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2294
Build 2303: arc lint + arc unit

Event Timeline

mmokhi updated this revision to Diff 12769.Jan 27 2016, 5:57 PM
mmokhi retitled this revision from to Fixing kbd.c bug 'OGIO_KEYMAP command does not restore priority level'.
mmokhi updated this object.
mmokhi edited the test plan for this revision. (Show Details)
mmokhi added a subscriber: mmokhi.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 27 2016, 5:57 PM
mmokhi added a comment.Jan 27 2016, 6:18 PM

related bugzilla issue:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206678

cem accepted this revision.Jan 27 2016, 6:23 PM
cem added a reviewer: cem.
cem added a subscriber: cem.
cem added inline comments.
sys/dev/kbd/kbd.c
887

Drop the comment, and use it in the commit message. Otherwise, looks good.

This revision is now accepted and ready to land.Jan 27 2016, 6:23 PM
mmokhi updated this revision to Diff 12770.EditedJan 27 2016, 6:30 PM
mmokhi edited edge metadata.

Updating D5095: Fixing kbd.c bug 'OGIO_KEYMAP command does not restore priority level'

Using 'break;' instead of 'return 0;' to call 'splx(s);' before 'return 0;'
Extra comment removed from code.

This revision now requires review to proceed.Jan 27 2016, 6:30 PM
cem accepted this revision.Jan 27 2016, 6:40 PM
cem edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2016, 6:40 PM
mmokhi marked an inline comment as done.Feb 11 2016, 5:07 PM
lifanov added a reviewer: matthew.Jan 7 2017, 1:54 PM
lifanov added a subscriber: lifanov.Jan 7 2017, 1:58 PM

Hi matthew, this was sitting around for a while.
I would like to commit it with this message:

Restore priority value for OGIO_KEYMAP 

PR: 206678
Submitted by: ecturt@gmail.com
Reviewed by: cem
Approved by: cem, matthew (mentor)
Differential Revision: https://reviews.freebsd.org/D5095
matthew accepted this revision.Jan 7 2017, 3:13 PM
matthew edited edge metadata.

If cem approves, then so do I.

Closed by commit rS311650: Restore priority value for OGIO_KEYMAP (authored by lifanov). · Explain WhyJan 7 2017, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
kbd/
2 lines

Diff 12769

View Options

sys/dev/kbd/kbd.c

Loading...