Page MenuHomeFreeBSD

inpcb: return ENOMEM if bind(2) fails to allocate lbgroup
AcceptedPublic

Authored by glebius on Thu, Feb 27, 6:24 AM.

Details

Reviewers
markj
Group Reviewers
network
Summary

The SO_REUSEPORT_LB isn't a standard option, neither ENOMEM is a specified
return code from bind(2), but it definitely is more appropriate than
EAGAIN or the masked ENOBUFS.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62657
Build 59541: arc lint + arc unit

Event Timeline

markj added inline comments.
sys/netinet/in_pcb.c
736

What's the purpose of this assertion? If you want to document that in_pcbinshash() can only fail for lbgroup sockets, IMO it would be better to somehow document that fact in in_pcbinshash().

This revision is now accepted and ready to land.Thu, Feb 27, 2:26 PM